Skip to content

Commit

Permalink
[Chromecast] Disable net_unittests with sanitizers.
Browse files Browse the repository at this point in the history
Exclude all net_unittests test when run with sanitizers. The previous
syntax didn't work because -= isn't supported for lists of scopes yet.
This also has the advantage of net_unittests still getting built.

TEST=local msan with with build script builder uses.
BUG=None

Review-Url: https://codereview.chromium.org/2420773002
Cr-Commit-Position: refs/heads/master@{#425213}
  • Loading branch information
mbjorge authored and Commit bot committed Oct 14, 2016
1 parent ee40051 commit f3f79af
Showing 1 changed file with 7 additions and 10 deletions.
17 changes: 7 additions & 10 deletions chromecast/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,13 @@ cast_test_group("cast_tests") {

net_unittests_filter = {
test_name = "net_unittests"
if (target_os == "linux" && !is_cast_desktop_build) {
if (using_sanitizer) {
# TODO(mbjorge): net_unittests do not complete when run with sanitizers,
# (in particular, TSAN and UBSAN), resulting in build machines getting stuck
# for many hours. Disable them for now, since these are getting run on
# Chromium bots anyway. (internal b/31279943)
gtest_excludes = [ "*" ]
} else if (target_os == "linux" && !is_cast_desktop_build) {
# Run net_unittests first to avoid random failures due to slow python startup
# KeygenHandlerTest.SmokeTest and KeygenHandlerTest.ConcurrencyTest fail due to
# readonly certdb (b/8153161)
Expand Down Expand Up @@ -230,15 +236,6 @@ cast_test_group("cast_tests") {
}
}
filters += [ net_unittests_filter ]

# TODO(mbjorge): net_unittests do not complete when run with sanitizers,
# (in particular, TSAN and UBSAN), resulting in build machines getting stuck
# for many hours. Disable them for now, since these are getting run on
# Chromium bots anyway. (internal b/31279943)
if (using_sanitizer) {
tests -= [ "//net:net_unittests" ]
filters -= [ net_unittests_filter ]
}
}

# Creates the build and run lists for all test targets.
Expand Down

0 comments on commit f3f79af

Please sign in to comment.