Skip to content

Commit

Permalink
Re-enable filter_list_converter target in coverage build
Browse files Browse the repository at this point in the history
This was disabled in crrev.com/c/1688731 due to failures in linking of
filter_list_converter target. This has now been fixed.

BUG=981112

Change-Id: I3e4f5947d345c2c96dac6c3c2fe531309e7b827d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561442
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Auto-Submit: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831136}
  • Loading branch information
Karandeep Bhatia authored and Commit Bot committed Nov 25, 2020
1 parent 17c4555 commit ef35fb2
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -261,14 +261,9 @@ group("gn_all") {
deps += [
"//extensions:extensions_browsertests",
"//extensions:extensions_unittests",
"//extensions/browser/api/declarative_net_request/filter_list_converter",
"//extensions/shell:app_shell_unittests",
]

# TODO(crbug.com/981112): This target is failing to compile consistently in
# coverage build, remove this condition when the bug is fixed.
if (!use_clang_coverage) {
deps += [ "//extensions/browser/api/declarative_net_request/filter_list_converter" ]
}
}

if (enable_remoting) {
Expand Down

0 comments on commit ef35fb2

Please sign in to comment.