Skip to content

Commit

Permalink
Enable gn check for //remoting/host/security_key:*
Browse files Browse the repository at this point in the history
This change is part of a code health effort to enable gn check for
all directories. https://docs.google.com/document/d/1sGxV0nGGoavOuw6XodYQ9xiN1f8fIhrb32gwADr2cD4/edit

Bug: 1159013
Change-Id: I6103637fe69c1c9ff59d9534305a061cafb5f6a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3086102
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#910475}
  • Loading branch information
arichiv authored and Chromium LUCI CQ committed Aug 10, 2021
1 parent 34a51d9 commit eec49c9
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
1 change: 0 additions & 1 deletion .gn
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ no_check_targets = [
"//extensions:*", # 28 errors
"//headless:*", # 107 errors
"//ppapi/proxy:ipc_sources", # 13 errors
"//remoting/host/security_key:*", # 10 errors

"//third_party/icu/*",
"//third_party/libwebp:*", # 7 errors, https://crbug.com/800762
Expand Down
7 changes: 6 additions & 1 deletion remoting/host/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ source_set("host_main_headers") {
"//remoting/host/linux:remoting_native_messaging_host",
"//remoting/host/mac:remoting_native_messaging_host",
"//remoting/host/mac:remoting_native_messaging_host_executable",
"//remoting/host/security_key:main",
"//remoting/host/win:remoting_console",
"//remoting/host/win:remoting_core",
"//remoting/host/win:remoting_desktop",
Expand All @@ -98,7 +99,11 @@ source_set("host_main_headers") {
}

source_set("common_headers") {
visibility = [ ":base" ]
visibility = [
":base",
"//remoting/host/security_key:security_key",
"//remoting/host/security_key:test_support",
]
sources = [
"action_executor.h",
"audio_capturer.h",
Expand Down
4 changes: 4 additions & 0 deletions remoting/host/security_key/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ source_set("security_key") {
"//mojo/public/cpp/system",
"//net:net",
"//net/traffic_annotation:traffic_annotation",
"//remoting/host:common_headers",
"//remoting/host:host_extension",
"//remoting/proto",
"//remoting/protocol:protocol",
Expand Down Expand Up @@ -71,6 +72,7 @@ source_set("main") {
"//mojo/core/embedder",
"//remoting/host:base",
"//remoting/host:common",
"//remoting/host:host_main_headers",
]
}

Expand All @@ -82,6 +84,7 @@ if (is_win) {
host_predefines + [ "REMOTING_HOST_BINARY=BINARY_REMOTE_SECURITY_KEY" ]

deps = [
":main",
"//build/win:default_exe_manifest",
"//remoting/host/win:remoting_core",
"//remoting/host/win:remoting_windows_resources",
Expand Down Expand Up @@ -147,6 +150,7 @@ static_library("test_support") {
":security_key",
"//ipc",
"//remoting/host:common",
"//remoting/host:common_headers",
"//remoting/proto",
"//testing/gtest",
]
Expand Down

0 comments on commit eec49c9

Please sign in to comment.