Skip to content

Commit

Permalink
Give time to free the port when shutting down apache on OSX.
Browse files Browse the repository at this point in the history
Sometimes the next perf test would try to start the http server,
but the port wouldn't be available. This matches what we do on Linux.

In the long run, we should use a random port to avoid having to wait.

BUG=29228


Review URL: https://chromiumcodereview.appspot.com/10834299

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151449 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
tony@chromium.org committed Aug 14, 2012
1 parent ce596d3 commit ee7945e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion tools/python/google/platform_utils_mac.py
Original file line number Diff line number Diff line change
Expand Up @@ -140,4 +140,6 @@ def GetStopHttpdCommand(self):

if not self._httpd_cmd_string:
return ["true"] # Haven't been asked for the start cmd yet. Just pass.
return [self._bash, "-c", self._httpd_cmd_string + ' -k stop']
# Add a sleep after the shutdown because sometimes it takes some time for
# the port to be available again.
return [self._bash, "-c", self._httpd_cmd_string + ' -k stop && sleep 5']

0 comments on commit ee7945e

Please sign in to comment.