forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert of Chromecast: Play audio streams not supported by CMA via def…
…ault renderer (patchset chromium#5 id:70001 of https://codereview.chromium.org/973633002/) Reason for revert: Audio tests started failing consistently in the next build after this was checked in. See: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/3762 Not sure if this CL is the culprit, but seems the most likely one, so attempting a revert to see if it fixes the problem. Error: [ RUN ] AudioRecorderTest.BasicRecordAndStop ../../components/audio_modem/audio_recorder_unittest.cc:203: Failure Value of: IsRecording() Actual: false Expected: true ../../components/audio_modem/audio_recorder_unittest.cc:208: Failure Value of: IsRecording() Actual: false Expected: true ../../components/audio_modem/audio_recorder_unittest.cc:213: Failure Value of: IsRecording() Actual: false Expected: true [ FAILED ] AudioRecorderTest.BasicRecordAndStop (1292 ms) Original issue's description: > Chromecast: Play audio streams not supported by CMA via default renderer > > For Chromecast we want to choose which media renderer to use based on > the types of input content streams. We will use CMA media renderer for > media types that are supported by our hardware (H264, AAC, etc) and > will use the default media renderer for audio streams other than AAC > or Vorbis. This will allow us support software decoding of FLAC and > Opus via the default Chrome audio path. > > BUG=457959 > > Committed: https://crrev.com/2e583073b996e66d62f709dd2ffde9e1ef58b276 > Cr-Commit-Position: refs/heads/master@{#318941} TBR=gunsch@chromium.org,lcwu@chromium.org,dalecurtis@chromium.org,servolk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=457959 Review URL: https://codereview.chromium.org/981473003 Cr-Commit-Position: refs/heads/master@{#319033}
- Loading branch information
1 parent
87bd8b4
commit ee687fd
Showing
10 changed files
with
74 additions
and
296 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74 changes: 0 additions & 74 deletions
74
chromecast/renderer/media/chromecast_media_renderer_factory.cc
This file was deleted.
Oops, something went wrong.
43 changes: 0 additions & 43 deletions
43
chromecast/renderer/media/chromecast_media_renderer_factory.h
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
// Copyright 2014 The Chromium Authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
#include "chromecast/renderer/media/cma_media_renderer_factory.h" | ||
|
||
#include "base/command_line.h" | ||
#include "chromecast/media/cma/filters/cma_renderer.h" | ||
#include "chromecast/renderer/media/media_pipeline_proxy.h" | ||
#include "content/public/renderer/render_thread.h" | ||
|
||
namespace chromecast { | ||
namespace media { | ||
|
||
CmaMediaRendererFactory::CmaMediaRendererFactory(int render_frame_id) | ||
: render_frame_id_(render_frame_id) { | ||
} | ||
|
||
CmaMediaRendererFactory::~CmaMediaRendererFactory() { | ||
} | ||
|
||
scoped_ptr< ::media::Renderer> CmaMediaRendererFactory::CreateRenderer( | ||
const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner, | ||
::media::AudioRendererSink* audio_renderer_sink) { | ||
// TODO(erickung): crbug.com/443956. Need to provide right LoadType. | ||
LoadType cma_load_type = kLoadTypeMediaSource; | ||
scoped_ptr<MediaPipeline> cma_media_pipeline( | ||
new MediaPipelineProxy( | ||
render_frame_id_, | ||
content::RenderThread::Get()->GetIOMessageLoopProxy(), | ||
cma_load_type)); | ||
return scoped_ptr< ::media::Renderer>( | ||
new CmaRenderer(cma_media_pipeline.Pass())); | ||
} | ||
|
||
} // namespace media | ||
} // namespace chromecast |
Oops, something went wrong.