Skip to content

Commit

Permalink
Disable ExpandablePaymentHandlerBrowserTest.WindowClientReady
Browse files Browse the repository at this point in the history
[Android Sheriff] Disable ExpandablePaymentHandlerBrowserTest.WindowClientReady

This test is recent. It was introduced by:
https://chromium-review.googlesource.com/c/chromium/src/+/2037643

It is flaky on (at least) Android.
TBR=tedchoc@chromium.org,rouslan@chromium.org,maxlg@chromium.org>

Bug: 1075481
Change-Id: I3284b7deeba92946326410539d94c88e5b1c1d4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166185
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762781}
  • Loading branch information
ArthurSonzogni authored and Commit Bot committed Apr 27, 2020
1 parent 9ecd952 commit ea26a79
Showing 1 changed file with 10 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,17 @@
// found in the LICENSE file.

#include "base/test/scoped_feature_list.h"
#include "build/build_config.h"
#include "chrome/browser/flags/android/chrome_feature_list.h"
#include "chrome/test/payments/payment_request_platform_browsertest_base.h"
#include "net/test/embedded_test_server/embedded_test_server.h"

#if defined(OS_ANDROID)
#define DISABLE_ON_ANDROID(test_name) DISABLED_##test_name
#else
#define DISABLE_ON_ANDROID(test_name) test_name
#endif

namespace payments {
namespace {

Expand Down Expand Up @@ -112,7 +119,9 @@ IN_PROC_BROWSER_TEST_F(ExpandablePaymentHandlerBrowserTest,
}

// Make sure openWindow() can be resolved into window client.
IN_PROC_BROWSER_TEST_F(ExpandablePaymentHandlerBrowserTest, WindowClientReady) {
// Android: Flaky. See https://crbug.com/1075481.
IN_PROC_BROWSER_TEST_F(ExpandablePaymentHandlerBrowserTest,
DISABLE_ON_ANDROID(WindowClientReady)) {
std::string expected = "success";
EXPECT_EQ(expected, content::EvalJs(GetActiveWebContents(), "install()"));
EXPECT_EQ("app_is_ready",
Expand Down

0 comments on commit ea26a79

Please sign in to comment.