Skip to content

Commit

Permalink
gn win: Add breakpad_handler target, necessary to compile breakpad on…
Browse files Browse the repository at this point in the history
… win

(due to direct_dependent include_dirs)

R=brettw@chromium.org
TBR=thestig@chromium.org
BUG=354261

Review URL: https://codereview.chromium.org/448743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287930 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
scottmg@chromium.org committed Aug 7, 2014
1 parent c9ce446 commit e58447e
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 1 deletion.
31 changes: 31 additions & 0 deletions breakpad/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ config("client_config") {
}
}

config("handler_config") {
include_dirs = [
"src",
]
}

# minidump_stackwalk and minidump_dump are tool-type executables that do
# not build on iOS.
Expand Down Expand Up @@ -657,4 +662,30 @@ if (is_win) {
group("client") {
direct_dependent_configs = [ ":client_config" ]
}

source_set("breakpad_handler") {
configs += [ ":handler_config" ]
if (is_win) {
direct_dependent_configs = [ ":handler_config" ]
}

defines = [ "BREAKPAD_NO_TERMINATE_THREAD" ]

sources = [
"src/client/windows/crash_generation/client_info.cc",
"src/client/windows/crash_generation/client_info.h",
"src/client/windows/crash_generation/crash_generation_client.cc",
"src/client/windows/crash_generation/crash_generation_client.h",
"src/client/windows/crash_generation/crash_generation_server.cc",
"src/client/windows/crash_generation/crash_generation_server.h",
"src/client/windows/handler/exception_handler.cc",
"src/client/windows/handler/exception_handler.h",
"src/common/windows/guid_string.cc",
"src/common/windows/guid_string.h",
"src/google_breakpad/common/minidump_format.h",
"src/client/windows/crash_generation/minidump_generator.cc",
"src/client/windows/crash_generation/minidump_generator.h",
"src/common/windows/string_utils-inl.h",
]
}
}
6 changes: 5 additions & 1 deletion components/breakpad/app/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ source_set("lib") {
"crash_keys_win.cc",
"crash_keys_win.h",
]

include_dirs = [
"../../../breakpad/src",
]
}

# Note: if you depend on this target, you need to either link in
Expand Down Expand Up @@ -51,7 +55,7 @@ source_set("app") {
} else if (is_win) {
deps += [
"//sandbox",
#'../breakpad/breakpad.gyp:breakpad_handler', TODO(GYP)
"//breakpad:breakpad_handler",
#'../breakpad/breakpad.gyp:breakpad_sender', TODO(GYP)
]
} else if (is_posix && !is_ios &&
Expand Down

0 comments on commit e58447e

Please sign in to comment.