Skip to content

Commit

Permalink
cc/viz: Remove PaintFilter::ToString.
Browse files Browse the repository at this point in the history
R=enne@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iac62262f6c09fcfd9877b9fafca0bf7a3cb30545
Reviewed-on: https://chromium-review.googlesource.com/1076771
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562522}
  • Loading branch information
khushalsagar authored and Commit Bot committed May 29, 2018
1 parent c68fece commit e2b49b3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 10 deletions.
8 changes: 0 additions & 8 deletions cc/paint/paint_filter.h
Original file line number Diff line number Diff line change
Expand Up @@ -93,14 +93,6 @@ class CC_PAINT_EXPORT PaintFilter : public SkRefCnt {
return 0;
return cached_sk_filter_->countInputs();
}
std::string ToString() const {
if (!cached_sk_filter_)
return "Invalid filter";

SkString str;
cached_sk_filter_->toString(&str);
return str.c_str();
}
const CropRect* crop_rect() const {
return base::OptionalOrNullptr(crop_rect_);
}
Expand Down
6 changes: 4 additions & 2 deletions services/viz/public/cpp/compositing/struct_traits_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,10 @@ void ExpectEqual(const cc::FilterOperation& input,
EXPECT_EQ(input.zoom_inset(), output.zoom_inset());
break;
case cc::FilterOperation::REFERENCE: {
EXPECT_EQ(input.image_filter()->ToString(),
output.image_filter()->ToString());
ASSERT_EQ(!!input.image_filter(), !!output.image_filter());
if (input.image_filter()) {
EXPECT_EQ(*input.image_filter(), *output.image_filter());
}
break;
}
case cc::FilterOperation::ALPHA_THRESHOLD:
Expand Down

0 comments on commit e2b49b3

Please sign in to comment.