Skip to content

Commit

Permalink
Add additional checks to help diagnose issue 479537.
Browse files Browse the repository at this point in the history
BUG=479537

Review URL: https://codereview.chromium.org/1104513002

Cr-Commit-Position: refs/heads/master@{#326490}
  • Loading branch information
ohodson authored and Commit bot committed Apr 23, 2015
1 parent d3f30d0 commit df07d19
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions gin/v8_initializer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,16 @@ bool V8Initializer::LoadV8Snapshot() {
return false;

#if defined(V8_VERIFY_EXTERNAL_STARTUP_DATA)
return VerifyV8SnapshotFile(g_mapped_natives, g_natives_fingerprint) &&
VerifyV8SnapshotFile(g_mapped_snapshot, g_snapshot_fingerprint);
// TODO(oth) Remove these temporary CHECKs once http://crbug.com/479537 is
// fixed. These are just here to identify whether canary failures are
// due to verification or file/vm failures.
bool natives_ok =
VerifyV8SnapshotFile(g_mapped_natives, g_natives_fingerprint);
CHECK(natives_ok);
bool snapshot_ok =
VerifyV8SnapshotFile(g_mapped_snapshot, g_snapshot_fingerprint);
CHECK(snapshot_ok);
return natives_ok && snapshot_ok;
#else
return true;
#endif // V8_VERIFY_EXTERNAL_STARTUP_DATA
Expand Down

0 comments on commit df07d19

Please sign in to comment.