Skip to content

Commit

Permalink
Simplify the author check.
Browse files Browse the repository at this point in the history
2 lines removed!

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7144016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89182 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
maruel@chromium.org committed Jun 15, 2011
1 parent 10d9994 commit d8b50be
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions PRESUBMIT.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,7 @@ def _CheckAuthorizedAuthor(input_api, output_api):
valid_authors = [item.group(1).lower() for item in valid_authors if item]
if input_api.verbose:
print 'Valid authors are %s' % ', '.join(valid_authors)
if not any(
True for valid in valid_authors
if fnmatch.fnmatch(author.lower(), valid)):
if not any(fnmatch.fnmatch(author.lower(), valid) for valid in valid_authors):
return [output_api.PresubmitPromptWarning(
('%s is not in AUTHORS file. If you are a new contributor, please visit'
'\n'
Expand Down

0 comments on commit d8b50be

Please sign in to comment.