forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Currently, there are 5 different URL switches in google_apis/gaia/gaia_switches.cc that need to be manually set to set non-prod Gaia environment. This CL introduces a new command line switch to rule them all: --gaia-config=gaia_test.json A JSON config file allows to override all URLs available in google_apis/gaia/gaia_urls.h. For a format example take a look at google_apis/test/data/gaia/all_urls.json. The proposed design was chosen because of the following: - It allows to override each individual URL separately without bloating the command line. This can be useful for developers who run their own test instances. - It makes easy to hide test URLs used at Google in the internal repo. Bug: 1072731 Change-Id: I3c32c53f9dc27b01ceab8ef57eb71c00d5df0977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166197 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#771605}
- Loading branch information
Alex Ilin
authored and
Commit Bot
committed
May 25, 2020
1 parent
e05917f
commit d84591a
Showing
14 changed files
with
893 additions
and
86 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.