Skip to content

Commit

Permalink
[Code health] Convert /content/browser/gpu away from WebUI::RegisterD…
Browse files Browse the repository at this point in the history
…eprecatedMessageCallback

...to WebUI::RegisterMessageCallback. (In some cases some other deprecated
usages were converted, when fairly local).

This CL was uploaded by git cl split.

R=kbr@chromium.org

Bug: 1243386
Change-Id: Ie18c7242a36c61863252df2108c92be8f3d467fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3733330
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1018913}
  • Loading branch information
Maks Orlovich authored and Chromium LUCI CQ committed Jun 29, 2022
1 parent 097f9d9 commit d4cfc18
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions content/browser/gpu/gpu_internals_ui.cc
Original file line number Diff line number Diff line change
Expand Up @@ -710,8 +710,8 @@ class GpuMessageHandler
void OnGpuSwitched(gl::GpuPreference) override;

// Messages
void OnBrowserBridgeInitialized(const base::ListValue* list);
void OnCallAsync(const base::ListValue* list);
void OnBrowserBridgeInitialized(const base::Value::List& list);
void OnCallAsync(const base::Value::List& list);

// Submessages dispatched from OnCallAsync
std::unique_ptr<base::Value> OnRequestClientInfo(
Expand Down Expand Up @@ -744,17 +744,16 @@ GpuMessageHandler::~GpuMessageHandler() {
void GpuMessageHandler::RegisterMessages() {
DCHECK_CURRENTLY_ON(BrowserThread::UI);

web_ui()->RegisterDeprecatedMessageCallback(
web_ui()->RegisterMessageCallback(
"browserBridgeInitialized",
base::BindRepeating(&GpuMessageHandler::OnBrowserBridgeInitialized,
base::Unretained(this)));
web_ui()->RegisterDeprecatedMessageCallback(
web_ui()->RegisterMessageCallback(
"callAsync", base::BindRepeating(&GpuMessageHandler::OnCallAsync,
base::Unretained(this)));
}

void GpuMessageHandler::OnCallAsync(const base::ListValue* args) {
const base::Value::List& args_list = args->GetList();
void GpuMessageHandler::OnCallAsync(const base::Value::List& args_list) {
DCHECK_GE(args_list.size(), static_cast<size_t>(2));
// unpack args into requestId, submessage and submessageArgs
const base::Value& requestId = args_list[0];
Expand Down Expand Up @@ -791,7 +790,7 @@ void GpuMessageHandler::OnCallAsync(const base::ListValue* args) {
}

void GpuMessageHandler::OnBrowserBridgeInitialized(
const base::ListValue* args) {
const base::Value::List& args) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);

// Watch for changes in GPUInfo
Expand Down

0 comments on commit d4cfc18

Please sign in to comment.