Skip to content

Commit

Permalink
[Android] Temporarily suppress RTL start&end check error.
Browse files Browse the repository at this point in the history
The newest Android SDK had start&end attributes in non -v17 resources.
Temporarily change the checking script from error to warning so that
people can continue to work before it is fixed. This should be
reverted once the issue is addressed

BUG=None

Review URL: https://codereview.chromium.org/445753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287711 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
kkimlabs@chromium.org committed Aug 6, 2014
1 parent 7ca6070 commit d35a5f9
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions build/android/gyp/generate_v14_compatible_resources.py
Original file line number Diff line number Diff line change
Expand Up @@ -226,18 +226,18 @@ def VerifyV14ResourcesInDir(input_dir, resource_type):
don't use attributes that cause crashes on certain devices. Print an error if
they have."""
for input_filename in build_utils.FindInDirectory(input_dir, '*.xml'):
exception_message = ('error : ' + input_filename + ' has an RTL attribute, '
'i.e., attribute that has "start" or "end" in its name.'
' Pre-v17 resources should not include it because it '
'can cause crashes on certain devices. Please refer to '
'http://crbug.com/243952 for the details.')
warning_message = ('warning : ' + input_filename + ' has an RTL attribute, '
'i.e., attribute that has "start" or "end" in its name.'
' Pre-v17 resources should not include it because it '
'can cause crashes on certain devices. Please refer to '
'http://crbug.com/243952 for the details.')
dom = minidom.parse(input_filename)
if resource_type in ('layout', 'xml'):
if GenerateV14LayoutResourceDom(dom, input_filename, False):
raise Exception(exception_message)
print warning_message
elif resource_type == 'values':
if GenerateV14StyleResourceDom(dom, input_filename, False):
raise Exception(exception_message)
print warning_message


def AssertNoDeprecatedAttributesInDir(input_dir, resource_type):
Expand Down

0 comments on commit d35a5f9

Please sign in to comment.