Skip to content

Commit

Permalink
Add build dependency: ui/app_list uses ui/base/ime
Browse files Browse the repository at this point in the history
The code in ui/app_list/views/search_box_view.cc was importing
ui/base/ime/text_input_flags.h, which was violating a dependency,
resulting in a compile problem for a downstream project. Fixed by
allowing this dependency.

R=sadrul@chromium.org,mgiuca@chromium.org

Review URL: https://codereview.chromium.org/1127603002

Cr-Commit-Position: refs/heads/master@{#328506}
  • Loading branch information
bratell-at-opera authored and Commit bot committed May 6, 2015
1 parent 04ab5b9 commit d239049
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions ui/app_list/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ component("app_list") {
"//third_party/icu",
"//ui/accessibility",
"//ui/base",
"//ui/base/ime",
"//ui/compositor",
"//ui/events:events_base",
"//ui/gfx",
Expand Down
1 change: 1 addition & 0 deletions ui/app_list/app_list.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
'../../components/components.gyp:keyed_service_core',
'../../skia/skia.gyp:skia',
'../base/ui_base.gyp:ui_base',
'../base/ime/ui_base_ime.gyp:ui_base_ime',
'../compositor/compositor.gyp:compositor',
'../events/events.gyp:events_base',
'../gfx/gfx.gyp:gfx',
Expand Down

0 comments on commit d239049

Please sign in to comment.