Skip to content

Commit

Permalink
Add comment to HostResolver::CreateStandaloneNetworkBoundResolver
Browse files Browse the repository at this point in the history
Explicitly state that a non-nullopt value for
ManagerOptions::dns_config_overrides is not supported.

Bug: 1309094
Change-Id: Ic78a49a6d57e45398044bbf743db313cc08683e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3598858
Reviewed-by: Eric Orth <ericorth@chromium.org>
Commit-Queue: Stefano Duo <stefanoduo@google.com>
Cr-Commit-Position: refs/heads/main@{#995638}
  • Loading branch information
StefanoDuo authored and Chromium LUCI CQ committed Apr 25, 2022
1 parent dfe7d60 commit cfd17ae
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions net/dns/host_resolver.h
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,8 @@ class NET_EXPORT HostResolver {
// performed exclusively for `target_network`, lookups will fail if
// `target_network` disconnects. This can only be used by network-bound
// URLRequestContexts.
// Due to the current implementation, if `options` is specified, its
// DnsConfigOverrides parameter must be empty.
// Only implemented for Android starting from Marshmallow.
static std::unique_ptr<HostResolver> CreateStandaloneNetworkBoundResolver(
NetLog* net_log,
Expand Down

0 comments on commit cfd17ae

Please sign in to comment.