Skip to content

Commit

Permalink
Fix mouse-events/mousemove-between.html on WebKit Linux MSAN
Browse files Browse the repository at this point in the history
WPT test uievents/order-of-events/mouse-events/mousemove-between.html
timeout on WebKit Linux MSAN, because the mouse actions are generated
and sent too fast that some mouse moves maybe coalesced, so we missed
some mouse events. I added "pause" action for each mouse move, so that
we will handle each individual mouse move, so we will get the correct
mouse action sequence.


Bug: 1182532
Change-Id: I29e1d4832e9eb5b1ffb362d7c5e7475d1e34faf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2731228
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#859834}
  • Loading branch information
LanWei22 authored and Chromium LUCI CQ committed Mar 4, 2021
1 parent 168f525 commit cdc4a4d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
3 changes: 0 additions & 3 deletions third_party/blink/web_tests/MSANExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,3 @@ crbug.com/1177358 [ Linux ] http/tests/devtools/console/console-viewport-stick-t
crbug.com/1179829 [ Linux ] http/tests/devtools/a11y-axe-core/sources/scope-pane-a11y-test.js [ Pass Timeout ]
crbug.com/1179829 [ Linux ] http/tests/devtools/console/console-log-linkify-stack-in-errors.js [ Pass Timeout ]
crbug.com/1179829 [ Linux ] http/tests/devtools/sources/debugger-pause/pause-on-elements-panel.js [ Pass Timeout ]

# Sheriff 2021-03-03
crbug.com/1182532 [ Linux ] external/wpt/uievents/order-of-events/mouse-events/mousemove-between.html [ Pass Timeout ]
Original file line number Diff line number Diff line change
Expand Up @@ -115,11 +115,17 @@
// Inject mouse inputs.
await new test_driver.Actions()
.pointerMove(b_rect.right + 10, center_b_y)
.pause(50)
.pointerMove(0, 0, {origin: b})
.pause(50)
.pointerMove(b_rect.right + 10, center_b_y)
.pause(50)
.pointerMove(a_rect.right + 10, center_b_y)
.pause(50)
.pointerMove(c_rect.right + 10, center_c_y)
.pause(50)
.pointerMove(0, 0, {origin: c})
.pause(50)
.pointerMove(c_rect.right + 20, c_rect.bottom + 20)
.send();
};
Expand Down

0 comments on commit cdc4a4d

Please sign in to comment.