Skip to content

Commit

Permalink
[chromedriver] Disable two failed KeyConverter tests on Windows bot.
Browse files Browse the repository at this point in the history
BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/25102002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225744 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
chrisgao@chromium.org committed Sep 27, 2013
1 parent b0e6557 commit cd89997
Showing 1 changed file with 11 additions and 3 deletions.
14 changes: 11 additions & 3 deletions chrome/test/chromedriver/key_converter_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,14 @@ TEST(KeyConverter, ToggleModifiers) {
CheckEventsReleaseModifiers(keys, event_array, arraysize(event_array));
}

TEST(KeyConverter, AllShorthandKeys) {
#if defined(OS_WIN)
// https://code.google.com/p/chromedriver/issues/detail?id=546
#define MAYBE_AllShorthandKeys DISABLED_AllShorthandKeys
#else
#define MAYBE_AllShorthandKeys AllShorthandKeys
#endif

TEST(KeyConverter, MAYBE_AllShorthandKeys) {
KeyEvent event_array[] = {
CreateKeyDownEvent(ui::VKEY_RETURN, 0),
CreateCharEvent("\r", "\r", 0),
Expand Down Expand Up @@ -313,8 +320,9 @@ TEST(KeyConverter, AllEnglishKeyboardTextChars) {
}
}

#if defined(OS_LINUX)
// Fails on bots: crbug.com/174962
#if defined(OS_LINUX) || defined(OS_WIN)
// https://code.google.com/p/chromedriver/issues/detail?id=240
// https://code.google.com/p/chromedriver/issues/detail?id=546
#define MAYBE_AllSpecialWebDriverKeysOnEnglishKeyboard \
DISABLED_AllSpecialWebDriverKeysOnEnglishKeyboard
#else
Expand Down

0 comments on commit cd89997

Please sign in to comment.