Skip to content

Commit

Permalink
Expose "gl-composited-texture-quad-border" in about::flag.
Browse files Browse the repository at this point in the history
crrev.com/2198573002 added a flag to draw a green border on
texture quads that are GL composited.

This CL adds the flag to about:flag.

BUG=b/29430506

Review-Url: https://codereview.chromium.org/2199893002
Cr-Commit-Position: refs/heads/master@{#409957}
  • Loading branch information
DCastagna authored and Commit bot committed Aug 5, 2016
1 parent 34ace12 commit cb4ebbc
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 0 deletions.
6 changes: 6 additions & 0 deletions chrome/app/generated_resources.grd
Original file line number Diff line number Diff line change
Expand Up @@ -5373,6 +5373,12 @@ Keep your key file in a safe place. You will need it to create new versions of y
<message name="IDS_FLAGS_COMPOSITED_LAYER_BORDERS_DESCRIPTION" desc="Description of the 'Composited layer borders' lab.">
Renders a border around composited Render Layers to help debug and study layer compositing.
</message>
<message name="IDS_FLAGS_GL_COMPOSITED_TEXTURE_QUAD_BORDERS" desc="Name of the 'Composited layer borders' lab.">
GL composited texture quad borders
</message>
<message name="IDS_FLAGS_GL_COMPOSITED_TEXTURE_QUAD_BORDERS_DESCRIPTION" desc="Description of the 'Composited layer borders' lab.">
Renders a border around GL composited texture quads to help debug and study overlay support.
</message>
<message name="IDS_FLAGS_DEBUG_SHORTCUTS_NAME" desc="Name of the 'Debugging keyboard shortcuts' lab.">
Debugging keyboard shortcuts
</message>
Expand Down
4 changes: 4 additions & 0 deletions chrome/browser/about_flags.cc
Original file line number Diff line number Diff line change
Expand Up @@ -707,6 +707,10 @@ const FeatureEntry kFeatureEntries[] = {
{"composited-layer-borders", IDS_FLAGS_COMPOSITED_LAYER_BORDERS,
IDS_FLAGS_COMPOSITED_LAYER_BORDERS_DESCRIPTION, kOsAll,
SINGLE_VALUE_TYPE(cc::switches::kShowCompositedLayerBorders)},
{"gl-composited-texture-quad-borders",
IDS_FLAGS_GL_COMPOSITED_TEXTURE_QUAD_BORDERS,
IDS_FLAGS_GL_COMPOSITED_TEXTURE_QUAD_BORDERS_DESCRIPTION, kOsAll,
SINGLE_VALUE_TYPE(cc::switches::kGlCompositedTextureQuadBorder)},
#if defined(ENABLE_WEBRTC)
{"disable-webrtc-hw-decoding", IDS_FLAGS_WEBRTC_HW_DECODING_NAME,
IDS_FLAGS_WEBRTC_HW_DECODING_DESCRIPTION, kOsAndroid | kOsCrOS,
Expand Down
1 change: 1 addition & 0 deletions tools/metrics/histograms/histograms.xml
Original file line number Diff line number Diff line change
Expand Up @@ -82555,6 +82555,7 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="-1941852572" label="floating-virtual-keyboard"/>
<int value="-1940806558" label="enable-syncfs-directory-operation"/>
<int value="-1938263248" label="enable-extension-info-dialog"/>
<int value="-1934673791" label="gl-composited-texture-quad-border"/>
<int value="-1930720286" label="nacl-debug-mask"/>
<int value="-1928198763" label="enable-async-dns"/>
<int value="-1925117279" label="disable-quic-https"/>
Expand Down

0 comments on commit cb4ebbc

Please sign in to comment.