Skip to content

Commit

Permalink
Refactoring: Remove one of SyncChannel::Create
Browse files Browse the repository at this point in the history
This function is not used anywhere.

Change-Id: I4116ef0634a1db7b1aacfc5326e662ce3abfe136
Reviewed-on: https://chromium-review.googlesource.com/1144816
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577446}
  • Loading branch information
Hajime Hoshi authored and Commit Bot committed Jul 24, 2018
1 parent f09b898 commit cabba70
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 23 deletions.
14 changes: 0 additions & 14 deletions ipc/ipc_sync_channel.cc
Original file line number Diff line number Diff line change
Expand Up @@ -545,20 +545,6 @@ std::unique_ptr<SyncChannel> SyncChannel::Create(
return channel;
}

// static
std::unique_ptr<SyncChannel> SyncChannel::Create(
std::unique_ptr<ChannelFactory> factory,
Listener* listener,
const scoped_refptr<base::SingleThreadTaskRunner>& ipc_task_runner,
const scoped_refptr<base::SingleThreadTaskRunner>& listener_task_runner,
bool create_pipe_now,
base::WaitableEvent* shutdown_event) {
std::unique_ptr<SyncChannel> channel =
Create(listener, ipc_task_runner, listener_task_runner, shutdown_event);
channel->Init(std::move(factory), create_pipe_now);
return channel;
}

// static
std::unique_ptr<SyncChannel> SyncChannel::Create(
Listener* listener,
Expand Down
9 changes: 0 additions & 9 deletions ipc/ipc_sync_channel.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ class SyncHandleRegistry;

namespace IPC {

class ChannelFactory;
class SyncMessage;

// This is similar to ChannelProxy, with the added feature of supporting sending
Expand Down Expand Up @@ -88,14 +87,6 @@ class COMPONENT_EXPORT(IPC) SyncChannel : public ChannelProxy {
bool create_pipe_now,
base::WaitableEvent* shutdown_event);

static std::unique_ptr<SyncChannel> Create(
std::unique_ptr<ChannelFactory> factory,
Listener* listener,
const scoped_refptr<base::SingleThreadTaskRunner>& ipc_task_runner,
const scoped_refptr<base::SingleThreadTaskRunner>& listener_task_runner,
bool create_pipe_now,
base::WaitableEvent* shutdown_event);

// Creates an uninitialized sync channel. Call ChannelProxy::Init to
// initialize the channel. This two-step setup allows message filters to be
// added before any messages are sent or received.
Expand Down

0 comments on commit cabba70

Please sign in to comment.