Intents: Deduplicate host conditions in ARC intent filters

It's common for ARC intent filters to duplicate host conditions, due to
the way that conditions are specified in AndroidManifest.xml.

Deduplicating these hosts takes some one-off time during conversion from
ARC to App Service intent filters but saves space (especially since
intent filters are stored in multiple places in memory) and time (since
many operations need to compare against all hosts in the list).

On a device with a variety of Android apps installed (including Google
Maps, which has a notably large number of duplicated hosts), this change
reduced the size of the serialized PreferredApps file by ~15%.

Bug: 1251031
Change-Id: I69fda9bfce9c7e0252bd5e7984ff2b904879a593
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3195360
Reviewed-by: Maggie Cai <mxcai@chromium.org>
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/main@{#931875}

chrome/browser/apps/app_service/intent_util.cc

@@ -635,6 +635,13 @@ apps::mojom::IntentFilterPtr ConvertArcToAppServiceIntentFilter(
         authority.host(), apps::mojom::PatternMatchType::kNone));
   }
   if (!host_condition_values.empty()) {
+    // It's common for Android apps to include duplicate host conditions, we can
+    // de-duplicate these to reduce time/space usage down the line.
+    std::sort(host_condition_values.begin(), host_condition_values.end());
+    host_condition_values.erase(
+        std::unique(host_condition_values.begin(), host_condition_values.end()),
+        host_condition_values.end());
+
     auto host_condition = apps_util::MakeCondition(
         apps::mojom::ConditionType::kHost, std::move(host_condition_values));
     intent_filter->conditions.push_back(std::move(host_condition));

chrome/browser/apps/app_service/intent_util_unittest.cc

@@ -518,6 +518,38 @@ TEST_F(IntentUtilsTest, ConvertArcIntentFilter_ConvertsSimpleGlobToPrefix) {
   }
 }
 
+TEST_F(IntentUtilsTest, ConvertArcIntentFilter_DeduplicatesHosts) {
+  const char* kPackageName = "com.foo.bar";
+  const char* kPath = "/";
+  const char* kScheme = "https";
+  const char* kHost1 = "www.a.com";
+  const char* kHost2 = "www.b.com";
+
+  std::vector<arc::IntentFilter::AuthorityEntry> authorities;
+  authorities.emplace_back(kHost1, 0);
+  authorities.emplace_back(kHost2, 0);
+  authorities.emplace_back(kHost2, 0);
+  authorities.emplace_back(kHost1, 0);
+
+  std::vector<arc::IntentFilter::PatternMatcher> patterns;
+  patterns.emplace_back(kPath, arc::mojom::PatternType::PATTERN_PREFIX);
+
+  arc::IntentFilter arc_filter(kPackageName, {arc::kIntentActionView},
+                               std::move(authorities), std::move(patterns),
+                               {kScheme}, {});
+
+  IntentFilterPtr app_service_filter =
+      apps_util::ConvertArcToAppServiceIntentFilter(arc_filter);
+
+  for (auto& condition : app_service_filter->conditions) {
+    if (condition->condition_type == apps::mojom::ConditionType::kHost) {
+      ASSERT_EQ(2u, condition->condition_values.size());
+      ASSERT_EQ(kHost1, condition->condition_values[0]->value);
+      ASSERT_EQ(kHost2, condition->condition_values[1]->value);
+    }
+  }
+}
+
 #if defined(OS_CHROMEOS)
 TEST_F(IntentUtilsTest, CrosapiIntentConversion) {
   apps::mojom::IntentPtr original_intent =