Convert most of fast/repaint to use text based harness

The pixel-based repaint test harness is incompatible with compositing and has to go. The text-based harness can test everything that the pixel based version could. This converts almost everything over by switching tests using f/r/resources/repaint.js over to f/r/resources/text-based-repaint.js, fixes up a few tests to work, and converts a few tests that are actually just pixel tests (not repaint tests) to do only what they need to do to cover what they intend to cover. BUG=344105 Review URL: https://codereview.chromium.org/168243002 git-svn-id: svn://svn.chromium.org/blink/trunk@167542 bbb929c8-8fbe-4397-9dbb-9b2b20218538
marcosholgado · Feb 20, 2014 · c4d086f · c4d086f
1 parent 9fc53bb
commit c4d086f
Show file tree

Hide file tree

Showing 199 changed files with 450 additions and 342 deletions.
diff --git a/third_party/WebKit/LayoutTests/TestExpectations b/third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/fast/repaint/4776765.html b/third_party/WebKit/LayoutTests/fast/repaint/4776765.html
@@ -1,4 +1,4 @@
-<script src="resources/repaint.js" type="text/javascript"></script>
+<script src="resources/text-based-repaint.js" type="text/javascript"></script>
 <script type="text/javascript">
 function repaintTest() {
     document.execCommand("InsertParagraph");

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/absolute-position-change-containing-block.html b/third_party/WebKit/LayoutTests/fast/repaint/absolute-position-change-containing-block.html
@@ -1,7 +1,7 @@
 <html>
 <head>
     <link rel="stylesheet" href="resources/default.css">
-    <script src="resources/repaint.js" type="text/javascript"></script>
+    <script src="resources/text-based-repaint.js" type="text/javascript"></script>
     <script type="text/javascript">
         if (window.testRunner)
             testRunner.dumpAsTextWithPixelResults();

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/absolute-position-changed.html b/third_party/WebKit/LayoutTests/fast/repaint/absolute-position-changed.html
@@ -1,7 +1,7 @@
 <html>
 <head>
     <link rel="stylesheet" href="resources/default.css">
-    <script src="resources/repaint.js" type="text/javascript"></script>
+    <script src="resources/text-based-repaint.js" type="text/javascript"></script>
     <script type="text/javascript">
         if (window.testRunner)
             testRunner.dumpAsTextWithPixelResults();

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/absolute-position-moved.html b/third_party/WebKit/LayoutTests/fast/repaint/absolute-position-moved.html
@@ -1,7 +1,7 @@
 <html>
 <head>
     <link rel="stylesheet" href="resources/default.css">
-    <script src="resources/repaint.js" type="text/javascript"></script>
+    <script src="resources/text-based-repaint.js" type="text/javascript"></script>
     <script type="text/javascript">
         if (window.testRunner)
             testRunner.dumpAsTextWithPixelResults();

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/add-table-overpaint.html b/third_party/WebKit/LayoutTests/fast/repaint/add-table-overpaint.html
@@ -2,7 +2,7 @@
 <!DOCTYPE html>
 <html>
 <body onload="runRepaintTest()" style="margin: 0px">
-<script src="resources/repaint.js"></script>
+<script src="resources/text-based-repaint.js"></script>
 <style>
 td {
   height: 150px;

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/background-generated.html b/third_party/WebKit/LayoutTests/fast/repaint/background-generated.html
@@ -1,6 +1,6 @@
 <!DOCTYPE HTML>
 <head>
-    <script src="resources/repaint.js" type="text/javascript"></script>
+    <script src="resources/text-based-repaint.js" type="text/javascript"></script>
     <script type="text/javascript">
         function repaintTest()
         {

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/background-misaligned.html b/third_party/WebKit/LayoutTests/fast/repaint/background-misaligned.html
@@ -1,4 +1,4 @@
-<script src="resources/repaint.js"></script>
+<script src="resources/text-based-repaint.js"></script>
 <script>
     function repaintTest()
     {

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/background-scaling.html b/third_party/WebKit/LayoutTests/fast/repaint/background-scaling.html
@@ -1,6 +1,6 @@
 <html style="background-color: green;">
 <head> 
-<script src="resources/repaint.js" type="text/javascript" charset="utf-8"></script> 
+<script src="resources/text-based-repaint.js" type="text/javascript" charset="utf-8"></script> 
 <script type="text/javascript"> 
     function repaintTest()
     {

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/backgroundSizeRepaint.html b/third_party/WebKit/LayoutTests/fast/repaint/backgroundSizeRepaint.html
@@ -5,7 +5,7 @@
 <style type="text/css">
     div.test { width: 200px; height: 120px; border: 1px solid blue; padding: 10px; }
 </style>
-    <script src="resources/repaint.js" type="text/javascript"></script>
+    <script src="resources/text-based-repaint.js" type="text/javascript"></script>
     <script type="text/javascript">
        function repaintTest()
        {

diff --git a/..._party/WebKit/LayoutTests/fast/repaint/block-layout-inline-children-float-positioned.html b/..._party/WebKit/LayoutTests/fast/repaint/block-layout-inline-children-float-positioned.html
@@ -22,7 +22,7 @@
         }
     </script>
 
-    <script src="resources/repaint.js"></script>
+    <script src="resources/text-based-repaint.js"></script>
 
     <p>This is a test for regression against <a href="https://bugs.webkit.org/show_bug.cgi?id=40142">https://bugs.webkit.org/show_bug.cgi?id=40142</a></p>
 

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/block-layout-inline-children-replaced.html b/third_party/WebKit/LayoutTests/fast/repaint/block-layout-inline-children-replaced.html
@@ -19,7 +19,7 @@
         }
     </script>
 
-    <script src="resources/repaint.js"></script>
+    <script src="resources/text-based-repaint.js"></script>
 
     <p>This is a test for regression against <a href="https://bugs.webkit.org/show_bug.cgi?id=40142">https://bugs.webkit.org/show_bug.cgi?id=40142</a></p>
 

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/block-no-inflow-children.html b/third_party/WebKit/LayoutTests/fast/repaint/block-no-inflow-children.html
@@ -5,7 +5,7 @@
             document.getElementById("target").innerText += " la";
         }
     </script>
-    <script src="resources/repaint.js"></script>
+    <script src="resources/text-based-repaint.js"></script>
     <div style="height:200px; width:200px">
       <div style="position:absolute">
         <div id="target">La la la</div>

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/block-selection-gap-in-composited-layer.html b/third_party/WebKit/LayoutTests/fast/repaint/block-selection-gap-in-composited-layer.html
@@ -1,7 +1,6 @@
 <head>
-    <script src="resources/repaint.js" type="text/javascript" charset="utf-8"></script>
     <script type="text/javascript" charset="utf-8">
-    function repaintTest()
+    function runTest()
     {
         var target = document.getElementById("target");
         getSelection().setBaseAndExtent(target, 0, target.nextSibling, 1);
@@ -11,7 +10,7 @@
         #target::selection { background-color: #0f0; }
     </style>
 </head>
-<body onload="runRepaintTest()">
+<body onload="runTest()">
     <div style="-webkit-transform: translateZ(0); margin-top: 50px; margin-left: 50px;">
         <div id="target" style="background-color: red; width: 100px; height: 100px; position: absolute;"><br></div>a
     </div>

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/block-selection-gap-in-table-cell.html b/third_party/WebKit/LayoutTests/fast/repaint/block-selection-gap-in-table-cell.html
@@ -2,15 +2,14 @@
     <style>
         ::selection { background-color: red; }
     </style>
-    <script src="resources/repaint.js" type="text/javascript" charset="utf-8"></script>
     <script type="text/javascript" charset="utf-8">
-    function repaintTest()
+    function runTest()
     {
         sel.empty();
     }
     </script>
 </head>
-<body onload="runRepaintTest()">
+<body onload="runTest()">
 <table><tr><td style="width: 100px; height: 100px;"></td></tr><tr><td style="background-color: green;">&nbsp;<div id="target" style="display: inline-block; height: 100px; width: 10px;"></div></td></tr></table>
 <script>
     var sel = getSelection();

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/block-selection-gap-stale-cache-2.html b/third_party/WebKit/LayoutTests/fast/repaint/block-selection-gap-stale-cache-2.html
@@ -2,15 +2,14 @@
     <style>
         ::selection { background-color: red; }
     </style>
-    <script src="resources/repaint.js" type="text/javascript" charset="utf-8"></script>
     <script type="text/javascript" charset="utf-8">
-    function repaintTest()
+    function runTest()
     {
         sel.empty();
     }
     </script>
 </head>
-<body onload="runRepaintTest()">
+<body onload="runTest()">
 <div style="height: 100px; overflow-y: scroll;">
     <div style="margin-top: 50px;"><div id="target" style="display: inline-block; width: 100px; height: 100px;"></div><br></div>&nbsp;
 </div>

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/block-selection-gap-stale-cache.html b/third_party/WebKit/LayoutTests/fast/repaint/block-selection-gap-stale-cache.html
@@ -2,15 +2,14 @@
     <style>
         ::selection { background-color: red; }
     </style>
-    <script src="resources/repaint.js" type="text/javascript" charset="utf-8"></script>
     <script type="text/javascript" charset="utf-8">
-    function repaintTest()
+    function runTest()
     {
         sel.empty();
     }
     </script>
 </head>
-<body onload="runRepaintTest()">
+<body onload="runTest()">
 <div><div id="target" style="display: inline-block; width: 100px; height: 50px;"></div><br></div>&nbsp;
 <script>
     var sel = getSelection();

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/body-background-image.html b/third_party/WebKit/LayoutTests/fast/repaint/body-background-image.html
@@ -2,7 +2,7 @@
 <html>
 <head>
     <title></title>
-    <script src="resources/repaint.js"></script>
+    <script src="resources/text-based-repaint.js"></script>
     <script>
         function repaintTest()
         {

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/border-fit-lines.html b/third_party/WebKit/LayoutTests/fast/repaint/border-fit-lines.html
@@ -1,6 +1,6 @@
 <html>
 <head>
-    <script src="resources/repaint.js" type="text/javascript"></script>
+    <script src="resources/text-based-repaint.js" type="text/javascript"></script>
     <script type="text/javascript">
         function repaintTest()
         {

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/border-radius-repaint.html b/third_party/WebKit/LayoutTests/fast/repaint/border-radius-repaint.html
@@ -5,7 +5,7 @@
 <style type="text/css">
     div.test { vertical-align: top; width: 200px; height: 120px; border: 1px solid blue; padding: 10px; }
 </style>
-    <script src="resources/repaint.js" type="text/javascript"></script>
+    <script src="resources/text-based-repaint.js" type="text/javascript"></script>
     <script type="text/javascript">
        function repaintTest()
        {

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/border-repaint-glitch.html b/third_party/WebKit/LayoutTests/fast/repaint/border-repaint-glitch.html
@@ -5,7 +5,7 @@
 <style type="text/css">
     div.test { width: 200px; height: 120px; border: 1px solid blue; padding: 10px; }
 </style>
-    <script src="resources/repaint.js" type="text/javascript"></script>
+    <script src="resources/text-based-repaint.js" type="text/javascript"></script>
     <script type="text/javascript">
        function repaintTest()
        {

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/box-shadow-dynamic.html b/third_party/WebKit/LayoutTests/fast/repaint/box-shadow-dynamic.html
@@ -5,7 +5,7 @@
 <style type="text/css">
     div.test { width: 50px; height: 100px; padding: 10px; }
 </style>
-    <script src="resources/repaint.js" type="text/javascript"></script>
+    <script src="resources/text-based-repaint.js" type="text/javascript"></script>
     <script type="text/javascript">
        function repaintTest()
        {

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/box-shadow-inset-repaint.html b/third_party/WebKit/LayoutTests/fast/repaint/box-shadow-inset-repaint.html
@@ -7,7 +7,7 @@
             box-shadow: inset cyan 0 -60px 0 0;
         }
     </style>
-    <script src="resources/repaint.js" type="text/javascript"></script>
+    <script src="resources/text-based-repaint.js" type="text/javascript"></script>
     <script type="text/javascript">
     function repaintTest()
     {

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/bugzilla-3509.html b/third_party/WebKit/LayoutTests/fast/repaint/bugzilla-3509.html
@@ -1,7 +1,7 @@
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
 <html lang="en">
 <head>
-    <script src="resources/repaint.js" type="text/javascript"></script>
+    <script src="resources/text-based-repaint.js" type="text/javascript"></script>
     <script type="text/javascript">
        function repaintTest()
        {

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/bugzilla-5699.html b/third_party/WebKit/LayoutTests/fast/repaint/bugzilla-5699.html
@@ -2,7 +2,7 @@
         "http://www.w3.org/TR/html4/strict.dtd">
 <html lang="en">
 <head>
-    <script src="resources/repaint.js" type="text/javascript"></script>
+    <script src="resources/text-based-repaint.js" type="text/javascript"></script>
     <script type="text/javascript">
        function repaintTest()
        {

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/bugzilla-6278.html b/third_party/WebKit/LayoutTests/fast/repaint/bugzilla-6278.html
@@ -2,7 +2,7 @@
         "http://www.w3.org/TR/html4/strict.dtd">
 <html lang="en">
 <head>
-    <script src="resources/repaint.js" type="text/javascript"></script>
+    <script src="resources/text-based-repaint.js" type="text/javascript"></script>
     <script type="text/javascript">
        function repaintTest()
        {

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/bugzilla-6388.html b/third_party/WebKit/LayoutTests/fast/repaint/bugzilla-6388.html
@@ -2,7 +2,7 @@
         "http://www.w3.org/TR/html4/strict.dtd">
 <html lang="en">
 <head>
-    <script src="resources/repaint.js" type="text/javascript"></script>
+    <script src="resources/text-based-repaint.js" type="text/javascript"></script>
     <script type="text/javascript">
        function repaintTest()
        {

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/bugzilla-6473.html b/third_party/WebKit/LayoutTests/fast/repaint/bugzilla-6473.html
@@ -2,7 +2,7 @@
         "http://www.w3.org/TR/html4/strict.dtd">
 <html lang="en">
 <head>
-<script src="resources/repaint.js"></script>
+<script src="resources/text-based-repaint.js"></script>
 <script type="text/javascript">
 function finish()
 {

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/bugzilla-7235.html b/third_party/WebKit/LayoutTests/fast/repaint/bugzilla-7235.html
@@ -16,7 +16,7 @@
         background: green;
     }
     </style>
-    <script src="resources/repaint.js" type="text/javascript"></script>
+    <script src="resources/text-based-repaint.js" type="text/javascript"></script>
     <script type="text/javascript">
        function repaintTest()
        {

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/button-spurious-layout-hint.html b/third_party/WebKit/LayoutTests/fast/repaint/button-spurious-layout-hint.html
@@ -1,5 +1,5 @@
 <head>
-    <script src="resources/repaint.js" type="text/javascript"></script>
+    <script src="resources/text-based-repaint.js" type="text/javascript"></script>
     <script>
         function repaintTest()
         {

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/canvas-putImageData.html b/third_party/WebKit/LayoutTests/fast/repaint/canvas-putImageData.html
@@ -1,6 +1,6 @@
 <!-- Test for https://bugs.webkit.org/show_bug.cgi?id=46319 -->
 <head>
-    <script src="resources/repaint.js"></script>
+    <script src="resources/text-based-repaint.js"></script>
 </head>
 <body>
     <canvas id="canvas" width="100" height="100"></canvas> 

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/caret-outside-block.html b/third_party/WebKit/LayoutTests/fast/repaint/caret-outside-block.html
@@ -1,6 +1,6 @@
 <html>
 <head>
-    <script src="resources/repaint.js"></script>
+    <script src="resources/text-based-repaint.js"></script>
     <script>
         function repaintTest()
         {

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/caret-with-transformation.html b/third_party/WebKit/LayoutTests/fast/repaint/caret-with-transformation.html
@@ -1,4 +1,4 @@
-<script src="resources/repaint.js" type="text/javascript"></script>
+<script src="resources/text-based-repaint.js" type="text/javascript"></script>
 <script type="text/javascript">
 function repaintTest() {
     var div = document.getElementById("div");

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/change-transform.html b/third_party/WebKit/LayoutTests/fast/repaint/change-transform.html
@@ -1,6 +1,6 @@
 <html>
 <head>
-  <script src="resources/repaint.js"></script>
+  <script src="resources/text-based-repaint.js"></script>
   <script type="text/javascript" charset="utf-8">
     function repaintTest()
     {

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/child-of-sub-pixel-offset-composited-layer.html b/third_party/WebKit/LayoutTests/fast/repaint/child-of-sub-pixel-offset-composited-layer.html
@@ -23,7 +23,7 @@
 	border-color: green;
 }
 </style>
-<script src="resources/repaint.js" type="text/javascript"></script>
+<script src="resources/text-based-repaint.js" type="text/javascript"></script>
 </head>
 <body onload="runRepaintTest();">
 <div class="container">

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/clip-with-layout-delta.html b/third_party/WebKit/LayoutTests/fast/repaint/clip-with-layout-delta.html
@@ -15,7 +15,7 @@
             background: blue;
         }
     </style>
-    <script src="resources/repaint.js" type="text/javascript"></script>
+    <script src="resources/text-based-repaint.js" type="text/javascript"></script>
     <script type="text/javascript">
        function repaintTest()
        {

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/clipped-relative.html b/third_party/WebKit/LayoutTests/fast/repaint/clipped-relative.html
@@ -1,6 +1,6 @@
 <html>
 <head>
-    <script src="resources/repaint.js" type="text/javascript"></script>
+    <script src="resources/text-based-repaint.js" type="text/javascript"></script>
     <script type="text/javascript">
        function repaintTest()
        {

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/containing-block-position-change.html b/third_party/WebKit/LayoutTests/fast/repaint/containing-block-position-change.html
@@ -1,6 +1,6 @@
 <html>
 <head>
-    <script src="resources/repaint.js" type="text/javascript"></script>
+    <script src="resources/text-based-repaint.js" type="text/javascript"></script>
     <script type="text/javascript">
        function repaintTest()
        {

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/content-into-overflow.html b/third_party/WebKit/LayoutTests/fast/repaint/content-into-overflow.html
@@ -10,7 +10,7 @@
         #main-content { float: left; width: 100px; height: 80px; }
         #target3 { display: none; clear: both; height: 20px; background: green; }
     </style>
-    <script src="resources/repaint.js" type="text/javascript"></script>
+    <script src="resources/text-based-repaint.js" type="text/javascript"></script>
     <script>
         function repaintTest()
         {

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/continuation-after-outline.html b/third_party/WebKit/LayoutTests/fast/repaint/continuation-after-outline.html
@@ -2,15 +2,14 @@
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <head>
     <title>Test for http://bugs.webkit.org/show_bug.cgi?id=13680</title>
-    <script src="resources/repaint.js" type="text/javascript"></script>
     <script>
-        function repaintTest()
+        function runTest()
         {
             document.getElementById('t').style.outline = '';
         }
     </script>
 </head>
-<body onload="runRepaintTest();">
+<body onload="runTest();">
     <div style="width: 50px; text-align: center;">
         <span id="t" style="outline: auto;"><div style="width: 30px; height:40px; background-color: silver; margin: auto"></div>
             x

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/control-clip.html b/third_party/WebKit/LayoutTests/fast/repaint/control-clip.html
@@ -1,7 +1,7 @@
 <html>
 <head>
     <title></title>
-    <script src="resources/repaint.js"></script>
+    <script src="resources/text-based-repaint.js"></script>
     <script>
         function repaintTest()
         {

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/create-layer-repaint.html b/third_party/WebKit/LayoutTests/fast/repaint/create-layer-repaint.html
@@ -19,7 +19,7 @@
       width: 500px;
     }
   </style>
-  <script src="resources/repaint.js" type="text/javascript"></script>
+  <script src="resources/text-based-repaint.js" type="text/javascript"></script>
   <script>
     function repaintTest()
     {