Skip to content

Commit

Permalink
Enabling the following ChromeFrame tests which were failing because o…
Browse files Browse the repository at this point in the history
…f a crash in the Chrome renderer process in

the WebKit accessibility code. The WebKit bug https://bugs.webkit.org/show_bug.cgi?id=75279 was fixed last week.

KeyboardInput
WidgetModeIE_InitializeHidden
WidgetModeIE_ObjectFocus
FormPostBackForward
Core

TBR=robertshield
Review URL: http://codereview.chromium.org/9084001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116233 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
ananta@chromium.org committed Jan 4, 2012
1 parent 34c235d commit c2265df
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 10 deletions.
6 changes: 2 additions & 4 deletions chrome_frame/test/navigation_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -647,8 +647,7 @@ TEST_F(NavigationTest, DISABLED_DownloadInNewWindow) {
LaunchIEAndNavigate(kDownloadFromNewWin);
}

// Disabled, http://crbug.com/108508
TEST_P(FullTabNavigationTest, DISABLED_FormPostBackForward) {
TEST_P(FullTabNavigationTest, FormPostBackForward) {
bool in_cf = GetParam().invokes_cf();
// Navigate to the form-get.html page:
// - First set focus to chrome renderer window
Expand Down Expand Up @@ -993,8 +992,7 @@ ACTION(VerifySeleniumCoreTestResults) {
}

// Tests refreshing causes a page load.
// Disabled, http://crbug.com/108508
TEST_F(FullTabSeleniumTest, DISABLED_Core) {
TEST_F(FullTabSeleniumTest, Core) {
// Please see http://code.google.com/p/chromium/issues/detail?id=60987
// for more information on why this test is disabled for Vista with IE7.
if (base::win::GetVersion() == base::win::VERSION_VISTA &&
Expand Down
6 changes: 2 additions & 4 deletions chrome_frame/test/test_with_web_server.cc
Original file line number Diff line number Diff line change
Expand Up @@ -406,8 +406,7 @@ TEST_F(ChromeFrameTestWithWebServer, WidgetModeIE_NavigateURLRelative) {

const wchar_t kNavigateSimpleObjectFocus[] = L"simple_object_focus.html";

// Disabled, http://crbug.com/108508
TEST_F(ChromeFrameTestWithWebServer, DISABLED_WidgetModeIE_ObjectFocus) {
TEST_F(ChromeFrameTestWithWebServer, WidgetModeIE_ObjectFocus) {
SimpleBrowserTest(IE, kNavigateSimpleObjectFocus);
}

Expand Down Expand Up @@ -556,8 +555,7 @@ TEST_F(ChromeFrameTestWithWebServer, FullTabIE_CFInstallDismiss) {

const wchar_t kInitializeHiddenPage[] = L"initialize_hidden.html";

// Disabled, http://crbug.com/108508
TEST_F(ChromeFrameTestWithWebServer, DISABLED_WidgetModeIE_InitializeHidden) {
TEST_F(ChromeFrameTestWithWebServer, WidgetModeIE_InitializeHidden) {
SimpleBrowserTest(IE, kInitializeHiddenPage);
}

Expand Down
3 changes: 1 addition & 2 deletions chrome_frame/test/ui_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@ INSTANTIATE_TEST_CASE_P(CF, FullTabUITest,
testing::Values(CFInvocation::MetaTag()));

// Tests keyboard input.
// Disabled, http://crbug.com/108508
TEST_P(FullTabUITest, DISABLED_KeyboardInput) {
TEST_P(FullTabUITest, KeyboardInput) {
if (!GetParam().invokes_cf()) {
LOG(ERROR) << "Test not implemented for this configuration.";
return;
Expand Down

0 comments on commit c2265df

Please sign in to comment.