Skip to content

Commit

Permalink
Move viz::SharedBitmap header to viz/common/resources
Browse files Browse the repository at this point in the history
It was placed in viz/common/quads/ because it is used with quads, but
fits better in resources/ with things like TransferableResource where
it actually appears.

R=piman@chromium.org
TBR=sky

Bug: 722935
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I39ada3a3fbefd22bfd819d4c10ecfceb59fc1d68
Reviewed-on: https://chromium-review.googlesource.com/1079384
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563649}
  • Loading branch information
danakj authored and Commit Bot committed Jun 1, 2018
1 parent 40cc775 commit c1bc647
Show file tree
Hide file tree
Showing 22 changed files with 25 additions and 25 deletions.
2 changes: 1 addition & 1 deletion cc/layers/texture_layer_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@
#include "cc/trees/single_thread_proxy.h"
#include "components/viz/common/gpu/context_provider.h"
#include "components/viz/common/gpu/raster_context_provider.h"
#include "components/viz/common/quads/shared_bitmap.h"
#include "components/viz/common/resources/bitmap_allocation.h"
#include "components/viz/common/resources/returned_resource.h"
#include "components/viz/common/resources/shared_bitmap.h"
#include "components/viz/common/resources/transferable_resource.h"
#include "components/viz/service/display/software_output_device.h"
#include "components/viz/test/fake_output_surface.h"
Expand Down
2 changes: 1 addition & 1 deletion cc/resources/cross_thread_shared_bitmap.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
#include "base/memory/ref_counted.h"
#include "base/memory/shared_memory.h"
#include "cc/cc_export.h"
#include "components/viz/common/quads/shared_bitmap.h"
#include "components/viz/common/resources/resource_format.h"
#include "components/viz/common/resources/shared_bitmap.h"
#include "ui/gfx/geometry/size.h"

namespace cc {
Expand Down
2 changes: 1 addition & 1 deletion cc/resources/resource_pool.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
#include "base/trace_event/memory_dump_provider.h"
#include "base/unguessable_token.h"
#include "cc/cc_export.h"
#include "components/viz/common/quads/shared_bitmap.h"
#include "components/viz/common/resources/resource_format.h"
#include "components/viz/common/resources/resource_id.h"
#include "components/viz/common/resources/shared_bitmap.h"
#include "gpu/command_buffer/common/sync_token.h"
#include "third_party/khronos/GLES2/gl2.h"
#include "ui/gfx/color_space.h"
Expand Down
2 changes: 1 addition & 1 deletion cc/resources/shared_bitmap_id_registrar.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
#include "cc/cc_export.h"
#include "components/viz/common/quads/shared_bitmap.h"
#include "components/viz/common/resources/shared_bitmap.h"

namespace cc {
class CrossThreadSharedBitmap;
Expand Down
2 changes: 1 addition & 1 deletion cc/test/pixel_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
#include "components/viz/common/frame_sinks/copy_output_request.h"
#include "components/viz/common/frame_sinks/copy_output_result.h"
#include "components/viz/common/quads/compositor_frame_metadata.h"
#include "components/viz/common/quads/shared_bitmap.h"
#include "components/viz/common/resources/bitmap_allocation.h"
#include "components/viz/common/resources/shared_bitmap.h"
#include "components/viz/service/display/display_resource_provider.h"
#include "components/viz/service/display/gl_renderer.h"
#include "components/viz/service/display/output_surface_client.h"
Expand Down
2 changes: 1 addition & 1 deletion cc/test/pixel_test.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#include "cc/trees/layer_tree_settings.h"
#include "components/viz/client/client_resource_provider.h"
#include "components/viz/common/quads/render_pass.h"
#include "components/viz/common/quads/shared_bitmap.h"
#include "components/viz/common/resources/shared_bitmap.h"
#include "components/viz/service/display/gl_renderer.h"
#include "components/viz/service/display/output_surface.h"
#include "components/viz/service/display/skia_renderer.h"
Expand Down
2 changes: 1 addition & 1 deletion components/viz/client/shared_bitmap_reporter.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#define COMPONENTS_VIZ_CLIENT_SHARED_BITMAP_REPORTER_H_

#include "components/viz/client/viz_client_export.h"
#include "components/viz/common/quads/shared_bitmap.h"
#include "components/viz/common/resources/shared_bitmap.h"
#include "mojo/public/cpp/system/buffer.h"

namespace viz {
Expand Down
4 changes: 2 additions & 2 deletions components/viz/common/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,6 @@ viz_component("common") {
"quads/render_pass_draw_quad.cc",
"quads/render_pass_draw_quad.h",
"quads/selection.h",
"quads/shared_bitmap.cc",
"quads/shared_bitmap.h",
"quads/shared_quad_state.cc",
"quads/shared_quad_state.h",
"quads/solid_color_draw_quad.cc",
Expand All @@ -115,6 +113,8 @@ viz_component("common") {
"resources/resource_sizes.h",
"resources/return_callback.h",
"resources/returned_resource.h",
"resources/shared_bitmap.cc",
"resources/shared_bitmap.h",
"resources/single_release_callback.cc",
"resources/single_release_callback.h",
"resources/transferable_resource.cc",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "components/viz/common/quads/shared_bitmap.h"
#include "components/viz/common/resources/shared_bitmap.h"

#include <stddef.h>
#include <stdint.h>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#ifndef COMPONENTS_VIZ_COMMON_QUADS_SHARED_BITMAP_H_
#define COMPONENTS_VIZ_COMMON_QUADS_SHARED_BITMAP_H_
#ifndef COMPONENTS_VIZ_COMMON_RESOURCES_SHARED_BITMAP_H_
#define COMPONENTS_VIZ_COMMON_RESOURCES_SHARED_BITMAP_H_

#include <stddef.h>
#include <stdint.h>
Expand Down Expand Up @@ -47,4 +47,4 @@ class VIZ_COMMON_EXPORT SharedBitmap {

} // namespace viz

#endif // COMPONENTS_VIZ_COMMON_QUADS_SHARED_BITMAP_H_
#endif // COMPONENTS_VIZ_COMMON_RESOURCES_SHARED_BITMAP_H_
2 changes: 1 addition & 1 deletion components/viz/common/resources/transferable_resource.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
#include <vector>

#include "build/build_config.h"
#include "components/viz/common/quads/shared_bitmap.h"
#include "components/viz/common/resources/resource_format.h"
#include "components/viz/common/resources/resource_id.h"
#include "components/viz/common/resources/shared_bitmap.h"
#include "components/viz/common/viz_common_export.h"
#include "gpu/command_buffer/common/mailbox_holder.h"
#include "ui/gfx/buffer_types.h"
Expand Down
2 changes: 1 addition & 1 deletion components/viz/service/display/display_resource_provider.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
#include "base/threading/thread_checker.h"
#include "base/trace_event/memory_dump_provider.h"
#include "build/build_config.h"
#include "components/viz/common/quads/shared_bitmap.h"
#include "components/viz/common/resources/resource_id.h"
#include "components/viz/common/resources/return_callback.h"
#include "components/viz/common/resources/shared_bitmap.h"
#include "components/viz/common/resources/transferable_resource.h"
#include "components/viz/service/display/overlay_candidate.h"
#include "components/viz/service/display/resource_fence.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@
#include "build/build_config.h"
#include "cc/test/render_pass_test_utils.h"
#include "cc/test/resource_provider_test_utils.h"
#include "components/viz/common/quads/shared_bitmap.h"
#include "components/viz/common/resources/bitmap_allocation.h"
#include "components/viz/common/resources/resource_format_utils.h"
#include "components/viz/common/resources/returned_resource.h"
#include "components/viz/common/resources/shared_bitmap.h"
#include "components/viz/common/resources/single_release_callback.h"
#include "components/viz/service/display/shared_bitmap_manager.h"
#include "components/viz/test/test_context_provider.h"
Expand Down
2 changes: 1 addition & 1 deletion components/viz/service/display/shared_bitmap_manager.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include <memory>

#include "base/macros.h"
#include "components/viz/common/quads/shared_bitmap.h"
#include "components/viz/common/resources/shared_bitmap.h"
#include "mojo/public/cpp/system/buffer.h"

namespace gfx {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@
#include "components/viz/common/quads/compositor_frame_metadata.h"
#include "components/viz/common/quads/render_pass.h"
#include "components/viz/common/quads/render_pass_draw_quad.h"
#include "components/viz/common/quads/shared_bitmap.h"
#include "components/viz/common/quads/solid_color_draw_quad.h"
#include "components/viz/common/quads/tile_draw_quad.h"
#include "components/viz/common/resources/bitmap_allocation.h"
#include "components/viz/common/resources/shared_bitmap.h"
#include "components/viz/service/display/display_resource_provider.h"
#include "components/viz/service/display/software_output_device.h"
#include "components/viz/test/fake_output_surface.h"
Expand Down
2 changes: 1 addition & 1 deletion content/browser/renderer_host/render_widget_host_impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
#include "base/time/time.h"
#include "base/timer/elapsed_timer.h"
#include "build/build_config.h"
#include "components/viz/common/quads/shared_bitmap.h"
#include "components/viz/common/resources/shared_bitmap.h"
#include "components/viz/common/surfaces/frame_sink_id.h"
#include "content/browser/renderer_host/event_with_latency_info.h"
#include "content/browser/renderer_host/frame_token_message_queue.h"
Expand Down
2 changes: 1 addition & 1 deletion content/common/view_messages.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#include "cc/input/touch_action.h"
#include "components/viz/common/frame_sinks/begin_frame_args.h"
#include "components/viz/common/quads/compositor_frame.h"
#include "components/viz/common/quads/shared_bitmap.h"
#include "components/viz/common/resources/shared_bitmap.h"
#include "content/common/content_export.h"
#include "content/common/content_param_traits.h"
#include "content/common/date_time_suggestion.h"
Expand Down
2 changes: 1 addition & 1 deletion content/renderer/pepper/pepper_graphics_2d_host.cc
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@
#include "cc/paint/paint_flags.h"
#include "cc/resources/cross_thread_shared_bitmap.h"
#include "components/viz/common/gpu/context_provider.h"
#include "components/viz/common/quads/shared_bitmap.h"
#include "components/viz/common/resources/bitmap_allocation.h"
#include "components/viz/common/resources/resource_sizes.h"
#include "components/viz/common/resources/shared_bitmap.h"
#include "content/public/renderer/render_thread.h"
#include "content/public/renderer/renderer_ppapi_host.h"
#include "content/renderer/pepper/gfx_conversion.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@

#include "build/build_config.h"
#include "cc/layers/texture_layer.h"
#include "components/viz/common/quads/shared_bitmap.h"
#include "components/viz/common/resources/bitmap_allocation.h"
#include "components/viz/common/resources/shared_bitmap.h"
#include "components/viz/common/resources/transferable_resource.h"
#include "gpu/GLES2/gl2extchromium.h"
#include "gpu/command_buffer/client/gles2_interface.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@

#include "cc/layers/texture_layer.h"
#include "cc/resources/cross_thread_shared_bitmap.h"
#include "components/viz/common/quads/shared_bitmap.h"
#include "components/viz/common/resources/bitmap_allocation.h"
#include "components/viz/common/resources/shared_bitmap.h"
#include "components/viz/common/resources/transferable_resource.h"
#include "gpu/command_buffer/client/gles2_interface.h"
#include "third_party/blink/public/platform/platform.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@

#include "base/memory/shared_memory.h"
#include "base/numerics/checked_math.h"
#include "components/viz/common/quads/shared_bitmap.h"
#include "components/viz/common/resources/bitmap_allocation.h"
#include "components/viz/common/resources/shared_bitmap.h"
#include "components/viz/common/resources/single_release_callback.h"
#include "gpu/command_buffer/client/gles2_interface.h"
#include "gpu/command_buffer/common/capabilities.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include "base/threading/thread_checker.h"
#include "components/viz/client/shared_bitmap_reporter.h"
#include "components/viz/common/gpu/context_provider.h"
#include "components/viz/common/quads/shared_bitmap.h"
#include "components/viz/common/resources/shared_bitmap.h"
#include "components/viz/common/surfaces/parent_local_surface_id_allocator.h"
#include "mojo/public/cpp/bindings/binding.h"
#include "mojo/public/cpp/system/buffer.h"
Expand Down

0 comments on commit c1bc647

Please sign in to comment.