Skip to content

Commit

Permalink
Remove the integrated desktop Chrome To Mobile Service and UI.
Browse files Browse the repository at this point in the history
Remove ChromeToMobile service, factory, unittests, and UI.
Remove IDS_CHROME_TO_MOBILE* strings.
Remove IDC_CHROME_TO_MOBILE_PAGE and adjust IDC values.
Remove IDR_MOBILE and chrome/app/theme/*/mobile[_lit].png
Remove browser frame and location bar callers, consts.

Remove prefs::kChromeToMobileDeviceList from user profiles.
Add code in c/b/prefs/browser_prefs.cc to clear this value.

The UMA histograms will be removed in a related CL:
https://chromereviews.googleplex.com/9087014/

WontFix'ed issues related to this code, listed for future reference:
-Issue 120941: Chrome To Mobile: An error occured while sending the page.
-Issue 154709: Last selected mobile device not stored and automatically reselected
-Issue 154710: Ordering of mobile devices not consistent
-Issue 156843: Only acknowledge invalidation after device search is finished in ChromeToMobileService
-Issue 122183: Make ChromeToMobile API more testable, drop gmock.

BUG=260121
TEST=Dead user pref is cleared, no compile failures/crashes.
R=rfevang@chromium.org,battre@chromium.org,sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19256007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212219 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
msw@chromium.org committed Jul 18, 2013
1 parent 76bfc7f commit c0dd75d
Show file tree
Hide file tree
Showing 58 changed files with 12 additions and 4,231 deletions.
5 changes: 2 additions & 3 deletions chrome/app/chrome_command_ids.h
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,8 @@
#define IDC_ENCODING_MENU 35005
#define IDC_EMAIL_PAGE_LOCATION 35006
#define IDC_ADVANCED_PRINT 35007
#define IDC_CHROME_TO_MOBILE_PAGE 35008
#define IDC_PRINT_TO_DESTINATION 35009
#define IDC_BOOKMARK_PAGE_FROM_STAR 35010
#define IDC_PRINT_TO_DESTINATION 35008
#define IDC_BOOKMARK_PAGE_FROM_STAR 35009

// When adding a new encoding to this list, be sure to append it to the
// EncodingMenuController::kValidEncodingIds array in
Expand Down
49 changes: 0 additions & 49 deletions chrome/app/generated_resources.grd
Original file line number Diff line number Diff line change
Expand Up @@ -8019,11 +8019,6 @@ Keep your key file in a safe place. You will need it to create new versions of y
</message>
</if>

<!--Action Box menu-->
<message name="IDS_CHROME_TO_MOBILE" desc="The text for chrome to mobile menu item">
Send tab to device
</message>

<!--Script Bubble-->
<message name="IDS_SCRIPT_BUBBLE_HEADLINE" desc="The headline of the script bubble.">
Extensions interacting with this page:
Expand Down Expand Up @@ -9299,50 +9294,6 @@ The following plug-in is unresponsive: <ph name="PLUGIN_NAME">$1
</message>
</if>

<!-- Chrome To Mobile bubble messages -->
<message name="IDS_CHROME_TO_MOBILE_BUBBLE_SINGLE_TITLE" desc="Title of the bubble when a single device is available.">
Send this page to <ph name="DEVICE_NAME">$1<ex>Galaxy Nexus</ex></ph>.
</message>
<message name="IDS_CHROME_TO_MOBILE_BUBBLE_MULTI_TITLE" desc="Title of the bubble when multiple devices are available.">
Send this page to:
</message>
<message name="IDS_CHROME_TO_MOBILE_BUBBLE_SEND_COPY" desc="Checkbox for optionally sending an offline copy of the page to the device.">
Also send a copy for offline viewing (<ph name="PAGE_SIZE">$1<ex>111kB</ex></ph>)
</message>
<message name="IDS_CHROME_TO_MOBILE_BUBBLE_SEND_COPY_GENERATING" desc="Placeholder PAGE_SIZE text indicating that the offline copy is being generated.">
generating...
</message>
<message name="IDS_CHROME_TO_MOBILE_BUBBLE_SEND_COPY_FAILED" desc="Text indicating that the offline copy generation failed.">
An error occurred while generating the offline copy
</message>
<message name="IDS_CHROME_TO_MOBILE_BUBBLE_SEND" desc="Button to send the page to the target device.">
Send
</message>
<message name="IDS_CHROME_TO_MOBILE_BUBBLE_SENDING_0" desc="First animated text step indicating that the page is being sent to the device.">
Sending
</message>
<message name="IDS_CHROME_TO_MOBILE_BUBBLE_SENDING_1" desc="Second animated text step indicating that the page is being sent to the device.">
Sending.
</message>
<message name="IDS_CHROME_TO_MOBILE_BUBBLE_SENDING_2" desc="Third animated text step indicating that the page is being sent to the device.">
Sending..
</message>
<message name="IDS_CHROME_TO_MOBILE_BUBBLE_SENDING_3" desc="Fourth animated text step indicating that the page is being sent to the device.">
Sending...
</message>
<message name="IDS_CHROME_TO_MOBILE_BUBBLE_SENT" desc="Text indicating that the page has been sent to the device.">
Sent!
</message>
<message name="IDS_CHROME_TO_MOBILE_BUBBLE_ERROR" desc="Text indicating that an error occurred sending the page to the device.">
Error
</message>
<message name="IDS_CHROME_TO_MOBILE_BUBBLE_ERROR_MESSAGE" desc="The error message shown when an error occurs sending the page to the device.">
An error occurred while sending the page
</message>
<message name="IDS_CHROME_TO_MOBILE_BUBBLE_TOOLTIP" desc="The tooltip for the Chrome To Mobile button.">
Send this page to your device
</message>

<!-- Application window menu -->
<if expr="not pp_ifdef('use_titlecase')">
<message name="IDS_APP_MENU_RELOAD" desc="The reload menu in application windows">
Expand Down
1,117 changes: 0 additions & 1,117 deletions chrome/app/nibs/ChromeToMobileBubble.xib

This file was deleted.

Binary file removed chrome/app/theme/default_100_percent/common/mobile.png
Binary file not shown.
Binary file not shown.
Binary file removed chrome/app/theme/default_100_percent/mobile.png
Binary file not shown.
Binary file removed chrome/app/theme/default_100_percent/mobile_lit.png
Binary file not shown.
Binary file removed chrome/app/theme/default_200_percent/common/mobile.png
Binary file not shown.
Binary file not shown.
Binary file removed chrome/app/theme/default_200_percent/mobile.png
Binary file not shown.
Binary file removed chrome/app/theme/default_200_percent/mobile_lit.png
Binary file not shown.
2 changes: 0 additions & 2 deletions chrome/app/theme/theme_resources.grd
Original file line number Diff line number Diff line change
Expand Up @@ -474,8 +474,6 @@
<if expr="pp_ifdef('chromeos')">
<structure type="chrome_scaled_image" name="IDR_MIRROR_FLIP" file="mirror_flip.png" />
</if>
<structure type="chrome_scaled_image" name="IDR_MOBILE" file="mobile.png" />
<structure type="chrome_scaled_image" name="IDR_MOBILE_LIT" file="mobile_lit.png" />
<if expr="pp_ifdef('chromeos')">
<structure type="chrome_scaled_image" name="IDR_NETWORK_ADD_CONNECTION" file="cros/network_add_connection.png" />
<structure type="chrome_scaled_image" name="IDR_NETWORK_ERROR" file="cros/network_error.png" />
Expand Down
Binary file removed chrome/app/theme/touch_100_percent/mobile.png
Binary file not shown.
Binary file removed chrome/app/theme/touch_100_percent/mobile_lit.png
Binary file not shown.
Loading

0 comments on commit c0dd75d

Please sign in to comment.