Correct feature flag for Windows printing with XPS

Flag needed to be in printing/common, as flags in components are not
accessible when building other DLLs (such as printing.dll).

Bug: 1008222
Change-Id: I9233b01b7535621afc42f7b65b656ad541ab6a72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929913
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Alan Screen <awscreen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718194}

components/printing/browser/features.cc

@@ -7,12 +7,6 @@
 namespace printing {
 namespace features {
 
-#if defined(OS_WIN)
-// Use XPS for printing instead of GDI.
-const base::Feature kUseXpsForPrinting{"UseXpsForPrinting",
-                                       base::FEATURE_DISABLED_BY_DEFAULT};
-#endif
-
 #if defined(OS_MACOSX)
 const base::Feature kEnableCustomMacPaperSizes{
     "EnableCustomMacPaperSizes", base::FEATURE_DISABLED_BY_DEFAULT};

components/printing/browser/features.h

@@ -11,10 +11,6 @@
 namespace printing {
 namespace features {
 
-#if defined(OS_WIN)
-extern const base::Feature kUseXpsForPrinting;
-#endif
-
 #if defined(OS_MACOSX)
 extern const base::Feature kEnableCustomMacPaperSizes;
 #endif

printing/common/printing_features.cc

@@ -10,5 +10,11 @@ namespace features {
 const base::Feature kHarfBuzzPDFSubsetter{"HarfBuzzPDFSubsetter",
                                           base::FEATURE_ENABLED_BY_DEFAULT};
 
+#if defined(OS_WIN)
+// Use XPS for printing instead of GDI.
+const base::Feature kUseXpsForPrinting{"UseXpsForPrinting",
+                                       base::FEATURE_DISABLED_BY_DEFAULT};
+#endif
+
 }  // namespace features
 }  // namespace printing

printing/common/printing_features.h

@@ -6,13 +6,18 @@
 #define PRINTING_COMMON_PRINTING_FEATURES_H_
 
 #include "base/feature_list.h"
+#include "build/build_config.h"
 #include "printing/printing_export.h"
 
 namespace printing {
 namespace features {
 
 PRINTING_EXPORT extern const base::Feature kHarfBuzzPDFSubsetter;
 
+#if defined(OS_WIN)
+PRINTING_EXPORT extern const base::Feature kUseXpsForPrinting;
+#endif
+
 }  // namespace features
 }  // namespace printing