Skip to content

Commit

Permalink
[chrome-remote-control] Fix flakiness on docs.
Browse files Browse the repository at this point in the history
We need to wait for the scrollable region to exist before
scrollable_element_function runs.

Example failure:
http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%282%29/builds/18255/steps/scrolling_benchmark/logs/stdio

BUG=None
TEST=Manual

Review URL: https://codereview.chromium.org/11226048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163436 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
tonyg@chromium.org committed Oct 22, 2012
1 parent 3167a14 commit bfa0133
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tools/perf/page_sets/top_25.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,15 @@
"url": "https://drive.google.com",
"why": "productivity, top google properties",
"credentials": "google",
"wait_for_javascript_expression": "document.getElementsByClassName('doclistview-list').length",
"scrollable_element_function": "function(callback) { callback(document.getElementsByClassName('doclistview-list')[0]); }"
},
{
"name": "Docs (1 open document tab)",
"url": "https://docs.google.com/document/d/1X-IKNjtEnx-WW5JIKRLsyhz5sbsat3mfTpAPUSX3_s4/view",
"why": "productivity, top google properties; Sample doc in the link",
"credentials": "google",
"wait_for_javascript_expression": "document.getElementsByClassName('kix-appview-editor').length",
"scrollable_element_function": "function(callback) { callback(document.getElementsByClassName('kix-appview-editor')[0]); }"
},
{
Expand Down

0 comments on commit bfa0133

Please sign in to comment.