Skip to content

Commit

Permalink
Update pixel wrangling doc
Browse files Browse the repository at this point in the history
Add instructions for rubber stamping expectations.

Bug: 1159542
Change-Id: Ifc546f0e8915ed2291322d4af38a8066c40ac728
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611667
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840309}
  • Loading branch information
y-novikov authored and Chromium LUCI CQ committed Jan 5, 2021
1 parent 59212f4 commit bf93e27
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions docs/gpu/pixel_wrangling.md
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,10 @@ shift, and a calendar appointment.
how important it is to eliminate flakiness rather than hiding it.
1. For failures of rendering_representative_perf_tests please refer to its
[instructions on updating expectations][rendering_representative_perf_tests].
1. It's always better to have the CL reviewed properly, but for urgent
suppressions when no reviewer is available, it is possible to rubber
stamp the CL via adding `rubber-stamper@appspot.gserviceaccount.com` as
your reviewer, in addition to the regular reviewer.
1. For the remaining Gtest-style tests, use the [`DISABLED_`
modifier][gtest-DISABLED] to suppress any failures if necessary.

Expand Down

0 comments on commit bf93e27

Please sign in to comment.