Skip to content

Commit

Permalink
Migrate PasswordGenerationPopupViewViews to AXNodeData::SetNameChecked
Browse files Browse the repository at this point in the history
AXNodeData::SetName was marked as deprecated in favor of SetNameChecked
which includes DCHECKs for things expected to be true. This commit
migrates PasswordGenerationPopupViewViews from SetName to
SetNameChecked.

AX-Relnotes: n/a

Bug: 1348081
Change-Id: Ic395eb11810600935e3aceff7398cb86f46d34c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3907952
Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1053149}
  • Loading branch information
joanmarie authored and Chromium LUCI CQ committed Sep 29, 2022
1 parent c87d1b4 commit b888600
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ void PasswordGenerationPopupViewViews::GetAccessibleNodeData(
return;
}
node_data->role = ax::mojom::Role::kMenuItem;
node_data->SetName(base::JoinString(
node_data->SetNameChecked(base::JoinString(
{controller_->SuggestedText(), controller_->password()}, u" "));
node_data->SetDescription(controller_->HelpText());
}
Expand Down

0 comments on commit b888600

Please sign in to comment.