Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
mac: Add clang-format binary that can run on arm.
Normally we prefer having a dedicated binary each for intel and arm, but clang-format: 1. is pulled via a .sha1 file and the binary will be next to the .sha1 file 2. the location of the binary is referenced from depot_tools So adding a second binary would mean adding a second .sha1 file, and then we'd have to teach depot_tools to look in both places. And clang-format is reasonably small. So just make it a universal binary instead. I built clang-format at the same revision the intel-only binary was built at (eb85e90350e), using the steps in docs/updating_clang_format_binaries.md. The only change I made was to also pass `'-DCMAKE_OSX_ARCHITECTURES=arm64;x86_64'` to cmake (need to include the quotes, else the shell uses the `;` as statement terminator -- luckily the `../llvm` part was after it so cmake informed me of missing this at first). Bug: 1190868 Change-Id: I092c4b1e9d37ddd7aeb4caef7d612a8df44092f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2786107 Reviewed-by: Hans Wennborg <hans@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#866974}
- Loading branch information