Skip to content

Commit

Permalink
Fixes flakiness caused by https://crrev.com/c/2909862
Browse files Browse the repository at this point in the history
This CL fixes flakiness in
ProfileBrowserTestWithoutDestroyProfile.DestroyRegularProfileBeforeOTRs.
Before changing the pref value we should also make sure prefs_ exist
and ShutdownOnUIThread wasn't called.

Bug: 1217988
Change-Id: I5f9ccc7c28710f174d03aeef78aad33954dbb950
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2953346
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892131}
  • Loading branch information
Viktor Semeniuk authored and Chromium LUCI CQ committed Jun 14, 2021
1 parent d42cf17 commit b55dd31
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion components/password_manager/core/browser/password_store.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1328,7 +1328,7 @@ bool PasswordStore::RemoveOldGoogleLogins() {
}

void PasswordStore::MarkOldGoogleLoginsRemoved(bool success) {
if (success) {
if (success && prefs_ && !shutdown_called_) {
prefs_->SetBoolean(prefs::kWereOldGoogleLoginsRemoved, true);
}
}
Expand Down

0 comments on commit b55dd31

Please sign in to comment.