Clang plugin: *Overriding* method must have "virtual" keyword.

The overridden method is the one in the base class.
It's the overriding method that might be missing the "virtual" keyword.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8465020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109473 0039d316-1c4b-4281-b951-d872f2087c98

tools/clang/plugins/FindBadConstructs.cpp

@@ -142,7 +142,7 @@ class FindBadConstructsConsumer : public ChromeClassTester {
       loc = method->getInnerLocStart();
 
     if (method->isVirtual() && !method->isVirtualAsWritten())
-      emitWarning(loc, "Overridden method must have \"virtual\" keyword.");
+      emitWarning(loc, "Overriding method must have \"virtual\" keyword.");
 
     // Virtual methods should not have inline definitions beyond "{}".
     if (method->isVirtual() && method->hasBody() && method->hasInlineBody()) {

tools/clang/plugins/tests/virtual_methods.txt

@@ -2,7 +2,7 @@ In file included from virtual_methods.cpp:5:
 ./virtual_methods.h:17:36: warning: [chromium-style] virtual methods with non-empty bodies shouldn't be declared inline.
   virtual bool ComplainAboutThis() { return true; }
                                    ^
-./virtual_methods.h:23:3: warning: [chromium-style] Overridden method must have "virtual" keyword.
+./virtual_methods.h:23:3: warning: [chromium-style] Overriding method must have "virtual" keyword.
   void MethodHasNoArguments();
   ^
 2 warnings generated.