Skip to content

Commit

Permalink
Exclude TCMalloc tests when running under Valgrind.
Browse files Browse the repository at this point in the history
These tests are not likely to ever work as Valgrind is already wrapping
malloc/free and thus changing the allocator behavior. Disabling these
tests for now and have filed crbug.com/567315 to track a long-term
decision about what to do with these tests.

BUG=567315
TBR=ssid@chromium.org

Review URL: https://codereview.chromium.org/1503233002

Cr-Commit-Position: refs/heads/master@{#363597}
  • Loading branch information
reillyeon authored and Commit bot committed Dec 7, 2015
1 parent 59eec41 commit b201871
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions tools/valgrind/gtest_exclude/base_unittests.gtest.txt
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,7 @@ PlatformFile.TouchGetInfoPlatformFile

# Crashes under Valgrind, see http://crbug.com/355436
OutOfMemoryHandledTest.Unchecked*

# Running under Valgrind breaks TCMalloc tests, see https://crbug.com/567315
TCMallocTest.*
TCMallocFreeTest.*

0 comments on commit b201871

Please sign in to comment.