Skip to content

Commit

Permalink
Clean up unneeded ozone.gni imports
Browse files Browse the repository at this point in the history
The definitions in ozone.gni were intended to be private to //ui/ozone,
but there's no visibility checking for gni files so there's we've grown
a number of these imports. Remove them where we can easily do so.

Change-Id: Id7e9f924ef3bd7a37f446708e00aac21f51e8f71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429865
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810950}
  • Loading branch information
mspang authored and Commit Bot committed Sep 26, 2020
1 parent d70525a commit a9cf138
Show file tree
Hide file tree
Showing 14 changed files with 26 additions and 25 deletions.
10 changes: 2 additions & 8 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import("//third_party/openh264/openh264_args.gni")
import("//tools/ipc_fuzzer/ipc_fuzzer.gni")
import("//ui/base/ui_features.gni")
import("//ui/gl/features.gni")
import("//ui/ozone/ozone.gni")
import("//v8/gni/snapshot_toolchain.gni")
import("//v8/gni/v8.gni")

Expand Down Expand Up @@ -294,17 +293,12 @@ group("gn_all") {
if (use_ozone) {
deps += [
"//ui/ozone",
"//ui/ozone:ozone_unittests",
"//ui/ozone:unittests",
"//ui/ozone/demo",
"//ui/ozone/gl:ozone_gl_unittests",
]

if (ozone_platform_x11) {
deps += [ "//ui/ozone:ozone_x11_unittests" ]
}
}

if (use_x11 || ozone_platform_x11) {
if (use_x11) {
deps += [ "//ui/platform_window/x11:x11_unittests" ]
}

Expand Down
1 change: 0 additions & 1 deletion chrome/browser/chromeos/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import("//printing/buildflags/buildflags.gni")
import("//testing/libfuzzer/fuzzer_test.gni")
import("//third_party/libprotobuf-mutator/fuzzable_proto_library.gni")
import("//third_party/protobuf/proto_library.gni")
import("//ui/ozone/ozone.gni")

assert(is_chromeos)
assert(use_ozone)
Expand Down
1 change: 0 additions & 1 deletion chromecast/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import("//chromecast/build/tests/cast_test.gni")
import("//chromecast/chromecast.gni")
import("//media/media_options.gni")
import("//tools/grit/repack.gni")
import("//ui/ozone/ozone.gni")
import("//v8/gni/v8.gni")

if (chromecast_branding != "public") {
Expand Down
1 change: 0 additions & 1 deletion content/gpu/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import("//build/config/ui.gni")
import("//gpu/vulkan/features.gni")
import("//media/media_options.gni")
import("//ui/ozone/ozone.gni")

# This file depends on the legacy global sources assignment filter. It should
# be converted to check target platform before assigning source files to the
Expand Down
1 change: 0 additions & 1 deletion gpu/ipc/common/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import("//build/config/ui.gni")
import("//gpu/vulkan/features.gni")
import("//mojo/public/tools/bindings/mojom.gni")
import("//ui/ozone/ozone.gni")

group("common") {
if (is_component_build) {
Expand Down
1 change: 0 additions & 1 deletion media/gpu/mac/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import("//media/gpu/args.gni")
import("//media/media_options.gni")
import("//tools/generate_stubs/rules.gni")
import("//ui/gl/features.gni")
import("//ui/ozone/ozone.gni")

assert(is_mac)

Expand Down
1 change: 0 additions & 1 deletion media/gpu/v4l2/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import("//media/gpu/args.gni")
import("//testing/test.gni")
import("//tools/generate_stubs/rules.gni")
import("//ui/gl/features.gni")
import("//ui/ozone/ozone.gni")

assert(use_v4l2_codec)

Expand Down
3 changes: 1 addition & 2 deletions media/gpu/vaapi/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import("//media/gpu/args.gni")
import("//testing/test.gni")
import("//tools/generate_stubs/rules.gni")
import("//ui/gl/features.gni")
import("//ui/ozone/ozone.gni")

assert(is_linux || is_chromeos)
assert(use_vaapi)
Expand Down Expand Up @@ -173,7 +172,7 @@ source_set("common") {
"//ui/gfx:memory_buffer",
"//ui/gl",
]
if (ozone_platform_drm) {
if (use_ozone) {
deps += [ "//ui/ozone" ]
}

Expand Down
4 changes: 1 addition & 3 deletions remoting/host/it2me/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# found in the LICENSE file.

import("//build/config/features.gni")
import("//build/config/ui.gni")
import("//remoting/remoting_locales.gni")
import("//remoting/remoting_options.gni")
import("//remoting/remoting_version.gni")
Expand All @@ -14,9 +15,6 @@ if (is_mac) {
import("//build/config/mac/rules.gni")
import("//third_party/icu/config.gni")
}
if (is_chromeos) {
import("//ui/ozone/ozone.gni")
}

# This file depends on the legacy global sources assignment filter. It should
# be converted to check target platform before assigning source files to the
Expand Down
2 changes: 1 addition & 1 deletion services/viz/privileged/mojom/compositing/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

import("//build/config/ui.gni")
import("//mojo/public/tools/bindings/mojom.gni")
import("//ui/ozone/ozone.gni")

mojom("compositing") {
sources = [
Expand Down
2 changes: 1 addition & 1 deletion third_party/blink/public/mojom/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

import("//build/config/ui.gni")
import("//mojo/public/tools/bindings/mojom.gni")
import("//third_party/blink/public/public_features.gni")
import("//ui/ozone/ozone.gni")

if (is_android) {
import("//build/config/android/config.gni")
Expand Down
1 change: 0 additions & 1 deletion ui/display/util/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

import("//build/config/ui.gni")
import("//testing/libfuzzer/fuzzer_test.gni")
import("//ui/ozone/ozone.gni")

component("util") {
output_name = "display_util"
Expand Down
22 changes: 20 additions & 2 deletions ui/ozone/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,11 @@ component("ozone_base") {
# Everyone should depend on //ui/ozone instead except a handful of
# things that would otherwise create a cycle.
"//chromeos/system:system",
"//ui/base/ime/chromeos/*",
"//ui/events/ozone/*",
"//ui/ozone/common/*",
"//ui/ozone/public/mojom",
"//ui/ozone/platform/*",
"//ui/base/ime/chromeos/*",
"//ui/ozone/public/mojom",
]

configs += [ "//third_party/khronos:khronos_headers" ]
Expand Down Expand Up @@ -316,3 +316,21 @@ buildflag_header("buildflags") {
header = "buildflags.h"
flags = [ "OZONE_PLATFORM_X11=$ozone_platform_x11" ]
}

group("unittests") {
testonly = true

visibility += [ "*" ]

deps = [
":ozone_unittests",
"//ui/ozone/gl:ozone_gl_unittests",
]

if (ozone_platform_x11) {
deps += [
"//ui/ozone:ozone_x11_unittests",
"//ui/platform_window/x11:x11_unittests",
]
}
}
1 change: 0 additions & 1 deletion ui/views_content_client/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
# found in the LICENSE file.

import("//build/config/ui.gni")
import("//ui/ozone/ozone.gni")

# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
Expand Down

0 comments on commit a9cf138

Please sign in to comment.