Skip to content

Commit

Permalink
android+chromeos: Make sure 32-bit android arm builds use -mfloat-abi…
Browse files Browse the repository at this point in the history
…=softfp.

...even in Chrome OS builds that set `arm_float_abi = "hard"` for the
outer Chrome OS builds -- the inner android build (for arc) should still
use the regular Android softfloat abi.

Bug: 1144188
Change-Id: I3cf726ce4134ad4d8cce8def8647d5851c081a63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510772
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822841}
  • Loading branch information
nico authored and Commit Bot committed Oct 30, 2020
1 parent 17746d5 commit a1d26a8
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
6 changes: 6 additions & 0 deletions build/config/arm.gni
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,12 @@ if (current_cpu == "arm" || v8_current_cpu == "arm") {
} else {
arm_float_abi = "hard"
}
} else if (current_os == "android") {
# The build/toolchain/android:android_clang_arm toolchain explicitly
# enforces this, so that chromeos builds can customize arm_float_abi
# for the outer chromeos build without affecting the android portion of
# a chromeos build.
assert(arm_float_abi == "softfp")
}

if (arm_fpu == "") {
Expand Down
1 change: 1 addition & 0 deletions build/toolchain/android/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ android_clang_toolchain("android_clang_arm") {
binary_prefix = "arm-linux-androideabi"
toolchain_args = {
current_cpu = "arm"
arm_float_abi = "softfp"
}
}

Expand Down

0 comments on commit a1d26a8

Please sign in to comment.