Skip to content

Commit

Permalink
Convert the re2 GYP targets to be generated by GN.
Browse files Browse the repository at this point in the history
BUG=288991
R=bradnelson@google.com

Review URL: https://codereview.chromium.org/68853015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245254 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
brettw@chromium.org committed Jan 16, 2014
1 parent 00b2947 commit 9dca84a
Show file tree
Hide file tree
Showing 18 changed files with 18 additions and 104 deletions.
2 changes: 1 addition & 1 deletion build/all.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
'../media/cast/cast.gyp:*',
'../media/media.gyp:*',
'../mojo/mojo.gyp:*',
'../out/gn_gyp/third_party/re2/re2.gyp:re2',
'../ppapi/ppapi.gyp:*',
'../ppapi/ppapi_internal.gyp:*',
'../printing/printing.gyp:*',
Expand All @@ -65,7 +66,6 @@
'../third_party/npapi/npapi.gyp:*',
'../third_party/ots/ots.gyp:*',
'../third_party/qcms/qcms.gyp:*',
'../third_party/re2/re2.gyp:re2',
'../third_party/WebKit/public/all.gyp:*',
'../tools/gn/gn.gyp:*',
'../tools/perf/clear_system_cache/clear_system_cache.gyp:*',
Expand Down
2 changes: 1 addition & 1 deletion chrome/chrome_browser.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -2635,7 +2635,7 @@
'../third_party/libusb/libusb.gyp:libusb',
'../third_party/libyuv/libyuv.gyp:libyuv',
'../third_party/npapi/npapi.gyp:npapi',
'../third_party/re2/re2.gyp:re2',
'../out/gn_gyp/third_party/re2/re2.gyp:re2',
'../third_party/webrtc/modules/modules.gyp:desktop_capture',
'../ui/gl/gl.gyp:gl',
'../ui/surface/surface.gyp:surface',
Expand Down
2 changes: 1 addition & 1 deletion chrome/chrome_browser_chromeos.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
'../third_party/npapi/npapi.gyp:npapi',
'../third_party/protobuf/protobuf.gyp:protobuf_lite',
'../third_party/protobuf/protobuf.gyp:protoc#host',
'../third_party/re2/re2.gyp:re2',
'../out/gn_gyp/third_party/re2/re2.gyp:re2',
'../third_party/zlib/zlib.gyp:zlib',
'../ui/base/strings/ui_strings.gyp:ui_strings',
'../ui/events/events.gyp:dom4_keycode_converter',
Expand Down
2 changes: 1 addition & 1 deletion chrome/chrome_browser_extensions.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
'../third_party/icu/icu.gyp:icuuc',
'../third_party/leveldatabase/leveldatabase.gyp:leveldatabase',
'../third_party/libusb/libusb.gyp:libusb',
'../third_party/re2/re2.gyp:re2',
'../out/gn_gyp/third_party/re2/re2.gyp:re2',
'../third_party/webrtc/modules/modules.gyp:desktop_capture',
'../ui/base/strings/ui_strings.gyp:ui_strings',
'../ui/gfx/gfx.gyp:gfx',
Expand Down
2 changes: 1 addition & 1 deletion chrome/chrome_browser_ui.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -2633,7 +2633,7 @@
'../third_party/leveldatabase/leveldatabase.gyp:leveldatabase',
'../third_party/libjingle/libjingle.gyp:libjingle',
'../third_party/npapi/npapi.gyp:npapi',
'../third_party/re2/re2.gyp:re2',
'../out/gn_gyp/third_party/re2/re2.gyp:re2',
'../ui/compositor/compositor.gyp:compositor',
'../ui/surface/surface.gyp:surface',
'../ui/web_dialogs/web_dialogs.gyp:web_dialogs',
Expand Down
2 changes: 1 addition & 1 deletion chrome/chrome_common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@
'<(DEPTH)/extensions/extensions.gyp:extensions_common',
'<(DEPTH)/ipc/ipc.gyp:ipc',
'<(DEPTH)/third_party/adobe/flash/flash_player.gyp:flapper_version_h',
'<(DEPTH)/third_party/re2/re2.gyp:re2',
'<(DEPTH)/out/gn_gyp/third_party/re2/re2.gyp:re2',
'<(DEPTH)/third_party/widevine/cdm/widevine_cdm.gyp:widevine_cdm_version_h',
],
}, { # OS == ios
Expand Down
2 changes: 1 addition & 1 deletion chrome/chrome_renderer.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
'../third_party/icu/icu.gyp:icui18n',
'../third_party/icu/icu.gyp:icuuc',
'../third_party/npapi/npapi.gyp:npapi',
'../third_party/re2/re2.gyp:re2',
'../out/gn_gyp/third_party/re2/re2.gyp:re2',
'../third_party/widevine/cdm/widevine_cdm.gyp:widevine_cdm_version_h',
'../ui/surface/surface.gyp:surface',
'../webkit/child/webkit_child.gyp:webkit_child',
Expand Down
2 changes: 1 addition & 1 deletion chrome/tools/profile_reset/jtl_compiler.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
'product_name': 'jtl_compiler',
'dependencies': [
'../../../base/base.gyp:base',
'../../../third_party/re2/re2.gyp:re2',
'../../../out/gn_gyp/third_party/re2/re2.gyp:re2',
],
'sources': [
'../../browser/profile_resetter/jtl_foundation.h',
Expand Down
2 changes: 1 addition & 1 deletion components/plugins.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
'dependencies': [
'../gin/gin.gyp:gin',
'../skia/skia.gyp:skia',
'../third_party/re2/re2.gyp:re2',
'../out/gn_gyp/third_party/re2/re2.gyp:re2',
'../third_party/WebKit/public/blink.gyp:blink',
'../v8/tools/gyp/v8.gyp:v8',
],
Expand Down
2 changes: 1 addition & 1 deletion components/url_matcher.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
'dependencies': [
'../base/base.gyp:base',
'../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
'../third_party/re2/re2.gyp:re2',
'../out/gn_gyp/third_party/re2/re2.gyp:re2',
'../url/url.gyp:url_lib',
],
'include_dirs': [
Expand Down
2 changes: 1 addition & 1 deletion content/content_browser.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
'../crypto/crypto.gyp:crypto',
'../google_apis/google_apis.gyp:google_apis',
'../net/net.gyp:net',
'../out/gn_gyp/third_party/re2/re2.gyp:re2',
'../skia/skia.gyp:skia',
'../sql/sql.gyp:sql',
'../third_party/re2/re2.gyp:re2',
'../third_party/zlib/google/zip.gyp:zip',
'../third_party/zlib/zlib.gyp:zlib',
'../ui/accessibility/accessibility.gyp:accessibility',
Expand Down
2 changes: 1 addition & 1 deletion extensions/extensions.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
'../chrome/common/extensions/api/api.gyp:api',
'../components/components.gyp:url_matcher',
'../content/content.gyp:content_common',
'../third_party/re2/re2.gyp:re2',
'../out/gn_gyp/third_party/re2/re2.gyp:re2',
],
'include_dirs': [
'..',
Expand Down
2 changes: 1 addition & 1 deletion gpu/command_buffer_service.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
'../third_party/khronos/khronos.gyp:khronos_headers',
'../third_party/protobuf/protobuf.gyp:protobuf_lite',
'../third_party/smhasher/smhasher.gyp:cityhash',
'../third_party/re2/re2.gyp:re2',
'../out/gn_gyp/third_party/re2/re2.gyp:re2',
],
'sources': [
'command_buffer/service/async_pixel_transfer_delegate.cc',
Expand Down
2 changes: 1 addition & 1 deletion gpu/gpu_config.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{
'dependencies': [
'../base/base.gyp:base',
'../third_party/re2/re2.gyp:re2',
'../out/gn_gyp/third_party/re2/re2.gyp:re2',
'../ui/gl/gl.gyp:gl',
],
'include_dirs': [
Expand Down
2 changes: 1 addition & 1 deletion third_party/leveldatabase/leveldatabase.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
# base::LazyInstance is a template that pulls in dynamic_annotations so
# we need to explictly link in the code for dynamic_annotations.
'../../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
'../re2/re2.gyp:re2',
'../../out/gn_gyp/third_party/re2/re2.gyp:re2',
],
'conditions': [
['use_snappy', {
Expand Down
2 changes: 1 addition & 1 deletion third_party/libaddressinput/libaddressinput.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
'dependencies': [
'generated_messages',
'<(DEPTH)/base/base.gyp:base',
'<(DEPTH)/third_party/re2/re2.gyp:re2',
'<(DEPTH)/out/gn_gyp/third_party/re2/re2.gyp:re2',
],
'direct_dependent_settings': {
'include_dirs': [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

gyp_file = "//out/gn_gyp/third_party/re2/re2.gyp"

config("re2_config") {
include_dirs = [ "." ]
}

gyp_file = "re2.gyp"
external = true

static_library("re2") {
sources = [
"mswin/stdint.h",
Expand Down Expand Up @@ -70,7 +69,6 @@ static_library("re2") {

if (is_win) {
include_dirs = [ "mswin" ]
# TODO(brettw) 'msvs_disabled_warnings': [ 4018, 4722, 4267 ],
} else {
sources -= "mswin/stdint.h"
}
Expand Down
84 changes: 0 additions & 84 deletions third_party/re2/re2.gyp

This file was deleted.

0 comments on commit 9dca84a

Please sign in to comment.