Skip to content

Commit

Permalink
Adding additional logging for deobfuscate timeout
Browse files Browse the repository at this point in the history
We've been seeing timeouts but we really don't know why. Hopefully this
logging will make it obvious.

Bug: 1351023
Change-Id: I8e3d78715cc6c5c8f0f1203b0052414a107b944a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3881005
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1044687}
  • Loading branch information
Sam Maier authored and Chromium LUCI CQ committed Sep 8, 2022
1 parent 4732cdf commit 9d2349c
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion build/android/pylib/symbols/deobfuscator.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,18 @@ def deobfuscate_reader():
'deobfuscator: Close() called by another thread during join().')
return lines
if reader_thread.is_alive():
logging.error('deobfuscator: Timed out.')
logging.error('deobfuscator: Timed out after %f seconds with input:',
timeout)
# We are seeing timeouts but don't know why. Hopefully seeing the
# lines that cause timeouts can make it obvious what the deobfuscator
# is struggling with.
for l in lines:
logging.error(l)
logging.error('deobfuscator: End of timed out input.')
logging.error('deobfuscator: Timed out output was:')
for l in out_lines:
logging.error(l)
logging.error('deobfuscator: End of timed out output.')
self.Close()
return lines
return out_lines
Expand Down

0 comments on commit 9d2349c

Please sign in to comment.