Skip to content

Commit

Permalink
bot_update: Ensure create_manifest ignores repos with explicit None u…
Browse files Browse the repository at this point in the history
…rls.

Bug: 830306
Change-Id: Id87a6f2053c7e3cd489647d1cbbc8a83f2e585db
Reviewed-on: https://chromium-review.googlesource.com/1003326
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
  • Loading branch information
jbudorick authored and Commit Bot committed Apr 18, 2018
1 parent 85c7502 commit 9ccad56
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion recipes/recipe_modules/bot_update/resources/bot_update.py
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,9 @@ def create_manifest(gclient_output, patch_root, gerrit_ref):
revision = info.get('revision', '')
# The format of the url is "https://repo.url/blah.git@abcdefabcdef" or
# just "https://repo.url/blah.git"
url_split = info.get('url', '').split('@')
url_split = info.get('url')
if url_split is not None:
url_split = url_split.split('@')
if not revision and len(url_split) == 2:
revision = url_split[1]
if url_split:
Expand Down

0 comments on commit 9ccad56

Please sign in to comment.