Skip to content

Commit

Permalink
Revert 206507 "Move message_pump to base/message_loop."
Browse files Browse the repository at this point in the history
> Move message_pump to base/message_loop.
> 
> This also fixes some namespace usage inside the message pump files and updates all users of these files to use the new location.
> 
> BUG=
> R=sky@chromium.org
> 
> Review URL: https://codereview.chromium.org/17078005

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/16897005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206513 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
brettw@chromium.org committed Jun 14, 2013
1 parent bb4628a commit 9bf0b36
Show file tree
Hide file tree
Showing 77 changed files with 388 additions and 381 deletions.
2 changes: 1 addition & 1 deletion ash/display/display_change_observer_x11.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
#include "ash/display/display_manager.h"
#include "ash/shell.h"
#include "base/command_line.h"
#include "base/message_loop/message_pump_aurax11.h"
#include "base/message_pump_aurax11.h"
#include "chromeos/display/output_util.h"
#include "grit/ash_strings.h"
#include "ui/base/l10n/l10n_util.h"
Expand Down
2 changes: 1 addition & 1 deletion ash/shell.cc
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
#include "ash/display/display_error_dialog.h"
#include "ash/display/output_configurator_animation.h"
#include "base/chromeos/chromeos_version.h"
#include "base/message_loop/message_pump_aurax11.h"
#include "base/message_pump_aurax11.h"
#include "chromeos/display/output_configurator.h"
#include "content/public/browser/gpu_data_manager.h"
#include "content/public/common/content_switches.h"
Expand Down
2 changes: 1 addition & 1 deletion base/android/base_jni_registrar.cc
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
#include "base/android/thread_utils.h"
#include "base/basictypes.h"
#include "base/debug/trace_event.h"
#include "base/message_loop/message_pump_android.h"
#include "base/message_pump_android.h"
#include "base/power_monitor/power_monitor_android.h"

#if defined(GOOGLE_TV)
Expand Down
44 changes: 22 additions & 22 deletions base/base.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -247,21 +247,21 @@
'linux_util.h',
'md5.cc',
'md5.h',
'message_loop/message_pump_android.cc',
'message_loop/message_pump_android.h',
'message_loop/message_pump_glib.cc',
'message_loop/message_pump_glib.h',
'message_loop/message_pump_gtk.cc',
'message_loop/message_pump_gtk.h',
'message_loop/message_pump_io_ios.cc',
'message_loop/message_pump_io_ios.h',
'message_loop/message_pump_observer.h',
'message_loop/message_pump_aurax11.cc',
'message_loop/message_pump_aurax11.h',
'message_loop/message_pump_libevent.cc',
'message_loop/message_pump_libevent.h',
'message_loop/message_pump_mac.h',
'message_loop/message_pump_mac.mm',
'message_pump_android.cc',
'message_pump_android.h',
'message_pump_glib.cc',
'message_pump_glib.h',
'message_pump_gtk.cc',
'message_pump_gtk.h',
'message_pump_io_ios.cc',
'message_pump_io_ios.h',
'message_pump_observer.h',
'message_pump_aurax11.cc',
'message_pump_aurax11.h',
'message_pump_libevent.cc',
'message_pump_libevent.h',
'message_pump_mac.h',
'message_pump_mac.mm',
'metrics/field_trial.cc',
'metrics/field_trial.h',
'posix/file_descriptor_shuffle.cc',
Expand Down Expand Up @@ -526,9 +526,9 @@
'message_loop/message_loop_proxy_impl_unittest.cc',
'message_loop/message_loop_proxy_unittest.cc',
'message_loop/message_loop_unittest.cc',
'message_loop/message_pump_glib_unittest.cc',
'message_loop/message_pump_io_ios_unittest.cc',
'message_loop/message_pump_libevent_unittest.cc',
'message_pump_glib_unittest.cc',
'message_pump_io_ios_unittest.cc',
'message_pump_libevent_unittest.cc',
'metrics/sample_map_unittest.cc',
'metrics/sample_vector_unittest.cc',
'metrics/bucket_ranges_unittest.cc',
Expand Down Expand Up @@ -684,7 +684,7 @@
# Requires spawning processes.
['exclude', '^metrics/stats_table_unittest\\.cc$'],
# iOS does not use message_pump_libevent.
['exclude', '^message_loop/message_pump_libevent_unittest\\.cc$'],
['exclude', '^message_pump_libevent_unittest\\.cc$'],
],
'conditions': [
['coverage != 0', {
Expand Down Expand Up @@ -746,12 +746,12 @@
],
}, { # use_glib!=1
'sources!': [
'message_loop/message_pump_glib_unittest.cc',
'message_pump_glib_unittest.cc',
]
}],
['use_ozone == 1', {
'sources!': [
'message_loop/message_pump_glib_unittest.cc',
'message_pump_glib_unittest.cc',
]
}],
['OS == "win"', {
Expand All @@ -764,7 +764,7 @@
'file_descriptor_shuffle_unittest.cc',
'files/dir_reader_posix_unittest.cc',
'threading/worker_pool_posix_unittest.cc',
'message_loop/message_pump_libevent_unittest.cc',
'message_pump_libevent_unittest.cc',
],
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
'msvs_disabled_warnings': [
Expand Down
36 changes: 18 additions & 18 deletions base/base.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -301,16 +301,16 @@
'message_loop/message_loop_proxy.h',
'message_loop/message_loop_proxy_impl.cc',
'message_loop/message_loop_proxy_impl.h',
'message_loop/message_pump.cc',
'message_loop/message_pump.h',
'message_loop/message_pump_android.cc',
'message_loop/message_pump_android.h',
'message_loop/message_pump_default.cc',
'message_loop/message_pump_default.h',
'message_loop/message_pump_ozone.cc',
'message_loop/message_pump_ozone.h',
'message_loop/message_pump_win.cc',
'message_loop/message_pump_win.h',
'message_pump.cc',
'message_pump.h',
'message_pump_android.cc',
'message_pump_android.h',
'message_pump_default.cc',
'message_pump_default.h',
'message_pump_ozone.cc',
'message_pump_ozone.h',
'message_pump_win.cc',
'message_pump_win.h',
'metrics/sample_map.cc',
'metrics/sample_map.h',
'metrics/sample_vector.cc',
Expand Down Expand Up @@ -648,12 +648,12 @@
],
'sources!': [
'atomicops_internals_x86_gcc.cc',
'message_loop/message_pump_glib.cc',
'message_loop/message_pump_aurax11.cc',
'message_pump_glib.cc',
'message_pump_aurax11.cc',
],
}],
['<(toolkit_uses_gtk)==0 or >(nacl_untrusted_build)==1', {
'sources!': ['message_loop/message_pump_gtk.cc'],
'sources!': ['message_pump_gtk.cc'],
}],
['(OS != "linux" and <(os_bsd) != 1 and OS != "android") or >(nacl_untrusted_build)==1', {
'sources!': [
Expand Down Expand Up @@ -736,7 +736,7 @@
['include', '^mac/scoped_mach_port\\.'],
['include', '^mac/scoped_nsautorelease_pool\\.'],
['include', '^memory/discardable_memory_mac\\.'],
['include', '^message_loop/message_pump_mac\\.'],
['include', '^message_pump_mac\\.'],
['include', '^threading/platform_thread_mac\\.'],
['include', '^strings/sys_string_conversions_mac\\.'],
['include', '^time_mac\\.'],
Expand All @@ -747,7 +747,7 @@
['include', '^process_util_ios\\.mm$'],
],
'sources!': [
'message_loop/message_pump_libevent.cc'
'message_pump_libevent.cc'
],
}],
['OS == "ios" and _toolset == "host"', {
Expand Down Expand Up @@ -790,7 +790,7 @@
'event_recorder_stubs.cc',
'files/file_path_watcher_kqueue.cc',
'files/file_path_watcher_stub.cc',
'message_loop/message_pump_libevent.cc',
'message_pump_libevent.cc',
'posix/file_descriptor_shuffle.cc',
# Not using sha1_win.cc because it may have caused a
# regression to page cycler moz.
Expand All @@ -800,8 +800,8 @@
},],
['<(use_ozone) == 1', {
'sources!': [
'message_loop/message_pump_glib.cc',
'message_loop/message_pump_aurax11.cc',
'message_pump_glib.cc',
'message_pump_aurax11.cc',
]
}],
['OS == "linux" and >(nacl_untrusted_build)==0', {
Expand Down
2 changes: 1 addition & 1 deletion base/mac/scoped_sending_event.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include "base/base_export.h"
#include "base/basictypes.h"
#include "base/memory/scoped_nsobject.h"
#include "base/message_loop/message_pump_mac.h"
#include "base/message_pump_mac.h"

// Nested event loops can pump IPC messages, including
// script-initiated tab closes, which could release objects that the
Expand Down
8 changes: 4 additions & 4 deletions base/message_loop/message_loop.cc
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#include "base/logging.h"
#include "base/memory/scoped_ptr.h"
#include "base/message_loop/message_loop_proxy_impl.h"
#include "base/message_loop/message_pump_default.h"
#include "base/message_pump_default.h"
#include "base/metrics/histogram.h"
#include "base/metrics/statistics_recorder.h"
#include "base/run_loop.h"
Expand All @@ -25,13 +25,13 @@
#include "base/tracked_objects.h"

#if defined(OS_MACOSX)
#include "base/message_loop/message_pump_mac.h"
#include "base/message_pump_mac.h"
#endif
#if defined(OS_POSIX) && !defined(OS_IOS)
#include "base/message_loop/message_pump_libevent.h"
#include "base/message_pump_libevent.h"
#endif
#if defined(OS_ANDROID)
#include "base/message_loop/message_pump_android.h"
#include "base/message_pump_android.h"
#endif

#if defined(TOOLKIT_GTK)
Expand Down
Loading

0 comments on commit 9bf0b36

Please sign in to comment.