Skip to content

Commit

Permalink
Allow wildcard for corporate CLA. Add nvidia to AUTHORS.
Browse files Browse the repository at this point in the history
BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7003151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88891 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
maruel@chromium.org committed Jun 13, 2011
1 parent 20661f7 commit 9bb9cb8
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 8 deletions.
19 changes: 14 additions & 5 deletions AUTHORS
Original file line number Diff line number Diff line change
@@ -1,7 +1,15 @@
# Names should be added to this file like so:
# Name or Organization <email address>
# Names should be added to this file with this pattern:
#
# For individuals:
# Name <email address>
#
# For organizations:
# Organization <fnmatch pattern>
#
# See python fnmatch module documentation for more information.

Google Inc.
The Chromium Authors <*@chromium.org>
Google Inc. <*@google.com>
Seo Sanghyeon <sanxiyn@gmail.com>
Alex Scheele <alexscheele@gmail.com>
Andrew Brampton <me@bramp.net>
Expand Down Expand Up @@ -71,7 +79,7 @@ Chamal De Silva <chamal.desilva@gmail.com>
Jay Soffian <jaysoffian@gmail.com>
Brian G. Merrell <bgmerrell@gmail.com>
Matthew Willis <appamatto@gmail.com>
Novell Inc.
Novell Inc. <*@novell.com>
Ryan Sleevi <ryan.sleevi@gmail.com>
Satoshi Matsuzaki <satoshi.matsuzaki@gmail.com>
Benjamin Jemlich <pcgod99@gmail.com>
Expand All @@ -80,7 +88,7 @@ Jared Wein <weinjared@gmail.com>
Mingmin Xie <melvinxie@gmail.com>
Michael Gilbert <floppymaster@gmail.com>
Giuseppe Iuculano <giuseppe@iuculano.it>
litl LLC
litl LLC <*@litl.com>
James Willcox <jwillcox@litl.com>
Shreyas VA <v.a.shreyas@gmail.com>
Steven Pennington <spenn@engr.uvic.ca>
Expand All @@ -104,3 +112,4 @@ David Futcher <bobbo@ubuntu.com>
Ramkumar Gokarnesan <ramgo@yahoo-inc.com>
Matt Arpidone <mma.public@gmail.com>
ruben <chromium@hybridsource.org>
NVIDIA Corporation <*@nvidia.com>
13 changes: 10 additions & 3 deletions PRESUBMIT.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,17 +96,24 @@ def _CheckAuthorizedAuthor(input_api, output_api):
"""For non-googler/chromites committers, verify the author's email address is
in AUTHORS.
"""
# TODO(maruel): Add it to input_api?
import fnmatch

author = input_api.change.author_email
if (author is None or author.endswith('@chromium.org') or
author.endswith('@google.com')):
if not author:
input_api.logging.info('No author, skipping AUTHOR check')
return []
authors_path = input_api.os_path.join(
input_api.PresubmitLocalPath(), 'AUTHORS')
valid_authors = (
input_api.re.match(r'[^#]+\s+\<(.+?)\>\s*$', line)
for line in open(authors_path))
valid_authors = [item.group(1).lower() for item in valid_authors if item]
if not author.lower() in valid_authors:
if input_api.verbose:
print 'Valid authors are %s' % ', '.join(valid_authors)
if not any(
True for valid in valid_authors
if fnmatch.fnmatch(author.lower(), valid)):
return [output_api.PresubmitPromptWarning(
('%s is not in AUTHORS file. If you are a new contributor, please visit'
'\n'
Expand Down

0 comments on commit 9bb9cb8

Please sign in to comment.