Download later: Fix an issue that positive button text could be wrong.

When selecting from date time picker option to other options in download
later dialog, the positive button should be "Done" instead of
"Download".

Bug: 1211732
Change-Id: Ib316a1a737586ffb620e3996c8a09076e9488a3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2912849
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#886023}

chrome/android/javatests/src/org/chromium/chrome/browser/download/dialogs/DownloadLaterDialogTest.java

@@ -295,4 +295,25 @@ public void testSelectFromOnWifiToDownloadLater() {
         verify(mController, times(0)).onDownloadLaterDialogComplete(anyInt(), anyLong());
         verify(mDateTimePicker).showDialog(any(), any(), any());
     }
+
+    @Test
+    @MediumTest
+    public void testSelectFromDownloadLaterToDownloadNow() {
+        showDialog();
+        TestThreadUtils.runOnUiThreadBlocking(() -> {
+            RadioButtonWithDescription downloadLaterButton =
+                    getDownloadLaterDialogView().findViewById(R.id.choose_date_time);
+            Assert.assertNotNull(downloadLaterButton);
+            downloadLaterButton.setChecked(true);
+            getDownloadLaterDialogView().onCheckedChanged(null, -1);
+
+            RadioButtonWithDescription onWifiButton =
+                    (RadioButtonWithDescription) getDownloadLaterDialogView().findViewById(
+                            org.chromium.chrome.browser.download.R.id.on_wifi);
+            onWifiButton.setChecked(true);
+            getDownloadLaterDialogView().onCheckedChanged(null, -1);
+        });
+
+        assertPositiveButtonText("Done");
+    }
 }

chrome/browser/download/android/java/src/org/chromium/chrome/browser/download/dialogs/DownloadLaterDialogCoordinator.java

@@ -267,7 +267,7 @@ private void onChoiceChanged(@DownloadLaterDialogChoice int choice) {
                 && choice != DownloadLaterDialogChoice.DOWNLOAD_LATER) {
             mDialogModel.set(ModalDialogProperties.POSITIVE_BUTTON_TEXT,
                     mContext.getResources().getString(
-                            R.string.duplicate_download_infobar_download_button));
+                            R.string.download_later_dialog_positive_button_text));
             mDownloadLaterDialogModel.set(
                     DownloadLaterDialogProperties.DONT_SHOW_AGAIN_DISABLED, false);
         }