Skip to content

Commit

Permalink
Reporting API: Remove Persister.
Browse files Browse the repository at this point in the history
We've decided to persist using SQLite, so there's no periodic "persist
everything" task that needs to happen, so the ReportingPersister no
longer needs to exist.

Bug: 
Change-Id: If229bc8cc5b946385c1f2934021b553cc5ae48fc
Reviewed-on: https://chromium-review.googlesource.com/797852
Commit-Queue: Julia Tuttle <juliatuttle@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521356}
  • Loading branch information
juliatuttle authored and Commit Bot committed Dec 4, 2017
1 parent 443a0a6 commit 9ae6625
Show file tree
Hide file tree
Showing 9 changed files with 2 additions and 451 deletions.
3 changes: 0 additions & 3 deletions net/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -1833,8 +1833,6 @@ component("net") {
"reporting/reporting_network_change_observer.h",
"reporting/reporting_observer.cc",
"reporting/reporting_observer.h",
"reporting/reporting_persister.cc",
"reporting/reporting_persister.h",
"reporting/reporting_policy.cc",
"reporting/reporting_policy.h",
"reporting/reporting_report.cc",
Expand Down Expand Up @@ -5372,7 +5370,6 @@ test("net_unittests") {
"reporting/reporting_garbage_collector_unittest.cc",
"reporting/reporting_header_parser_unittest.cc",
"reporting/reporting_network_change_observer_unittest.cc",
"reporting/reporting_persister_unittest.cc",
"reporting/reporting_service_unittest.cc",
"reporting/reporting_test_util.cc",
"reporting/reporting_test_util.h",
Expand Down
2 changes: 0 additions & 2 deletions net/reporting/reporting_context.cc
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#include "net/reporting/reporting_garbage_collector.h"
#include "net/reporting/reporting_network_change_observer.h"
#include "net/reporting/reporting_observer.h"
#include "net/reporting/reporting_persister.h"
#include "net/reporting/reporting_policy.h"
#include "net/reporting/reporting_uploader.h"

Expand Down Expand Up @@ -80,7 +79,6 @@ ReportingContext::ReportingContext(const ReportingPolicy& policy,
cache_(ReportingCache::Create(this)),
endpoint_manager_(ReportingEndpointManager::Create(this)),
delivery_agent_(ReportingDeliveryAgent::Create(this)),
persister_(ReportingPersister::Create(this)),
garbage_collector_(ReportingGarbageCollector::Create(this)),
network_change_observer_(ReportingNetworkChangeObserver::Create(this)) {}

Expand Down
6 changes: 0 additions & 6 deletions net/reporting/reporting_context.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ class ReportingEndpointManager;
class ReportingGarbageCollector;
class ReportingNetworkChangeObserver;
class ReportingObserver;
class ReportingPersister;
class ReportingUploader;
class URLRequestContext;

Expand Down Expand Up @@ -57,8 +56,6 @@ class NET_EXPORT ReportingContext {
return garbage_collector_.get();
}

ReportingPersister* persister() { return persister_.get(); }

void AddObserver(ReportingObserver* observer);
void RemoveObserver(ReportingObserver* observer);

Expand Down Expand Up @@ -91,9 +88,6 @@ class NET_EXPORT ReportingContext {
// |cache_|, and |endpoint_manager_|.
std::unique_ptr<ReportingDeliveryAgent> delivery_agent_;

// |persister_| must come after |clock_|, |tick_clock_|, and |cache_|.
std::unique_ptr<ReportingPersister> persister_;

// |garbage_collector_| must come after |tick_clock_| and |cache_|.
std::unique_ptr<ReportingGarbageCollector> garbage_collector_;

Expand Down
321 changes: 0 additions & 321 deletions net/reporting/reporting_persister.cc

This file was deleted.

Loading

0 comments on commit 9ae6625

Please sign in to comment.