Skip to content

Commit

Permalink
Update base::Value list usage in android_webview/
Browse files Browse the repository at this point in the history
In particular, use Value::List instead of base::Value::ListStorage /
std::vector<base::Value>.

Bug: 1338341
Change-Id: I440ffe07ac302cdfab923ddf54a0b2ff02602233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3767157
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1026908}
  • Loading branch information
Matt Menke authored and Chromium LUCI CQ committed Jul 21, 2022
1 parent 08beceb commit 9706dda
Showing 1 changed file with 7 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,17 @@ void EnterpriseAuthenticationAppLinkPolicyHandler::ApplyPolicySettings(
if (!value)
return;

std::vector<base::Value> filtered_values;
base::Value::List filtered_values;
for (const auto& entry : value->GetList()) {
const std::string* url = entry.FindStringKey("url");
if (ValidatePolicyEntry(url))
filtered_values.emplace_back(*url);
filtered_values.Append(*url);
}
if (filtered_values.size() > policy::kMaxUrlFiltersPerPolicy) {
filtered_values.erase(
filtered_values.begin() + policy::kMaxUrlFiltersPerPolicy,
filtered_values.end());
}
if (filtered_values.size() > policy::kMaxUrlFiltersPerPolicy)
filtered_values.resize(policy::kMaxUrlFiltersPerPolicy);

prefs->SetValue(pref_path_, base::Value(std::move(filtered_values)));
}
Expand Down

0 comments on commit 9706dda

Please sign in to comment.