Skip to content

Commit

Permalink
Remove DevTools survey API key
Browse files Browse the repository at this point in the history
This was going to be used for HaTS surveys in the DevTools frontend
but we ended up going with a different implementation where we share
code with the browser implementation, so we don't need our own API
key anymore. This was never used as it was just added in
preparation.

R=msarda@chromium.org

Bug: 1112738
Change-Id: Ibb92f40bdb1bad23b90320c5021c642961040e96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560499
Auto-Submit: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#832287}
  • Loading branch information
psmarshall authored and Chromium LUCI CQ committed Dec 1, 2020
1 parent 55029fe commit 95c1668
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 23 deletions.
19 changes: 0 additions & 19 deletions google_apis/google_api_keys.cc
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,6 @@
#define GOOGLE_API_KEY_SODA DUMMY_API_TOKEN
#endif

// API key for the DevTools frontend to use for surveys. Note there is no
// public API to replace this functionality.
#if !defined(GOOGLE_API_KEY_DEVTOOLS_SURVEYS)
#define GOOGLE_API_KEY_DEVTOOLS_SURVEYS DUMMY_API_TOKEN
#endif

// These are used as shortcuts for developers and users providing
// OAuth credentials via preprocessor defines or environment
// variables. If set, they will be used to replace any of the client
Expand Down Expand Up @@ -153,11 +147,6 @@ class APIKeyCache {
GOOGLE_API_KEY_SODA, STRINGIZE_NO_EXPANSION(GOOGLE_API_KEY_SODA),
nullptr, std::string(), environment.get(), command_line, gaia_config);

api_key_devtools_surveys_ = CalculateKeyValue(
GOOGLE_API_KEY_DEVTOOLS_SURVEYS,
STRINGIZE_NO_EXPANSION(GOOGLE_API_KEY_DEVTOOLS_SURVEYS), nullptr,
std::string(), environment.get(), command_line, gaia_config);

metrics_key_ = CalculateKeyValue(
GOOGLE_METRICS_SIGNING_KEY,
STRINGIZE_NO_EXPANSION(GOOGLE_METRICS_SIGNING_KEY), nullptr,
Expand Down Expand Up @@ -224,9 +213,6 @@ class APIKeyCache {
std::string api_key_remoting() const { return api_key_remoting_; }
std::string api_key_sharing() const { return api_key_sharing_; }
std::string api_key_soda() const { return api_key_soda_; }
std::string api_key_devtools_surveys() const {
return api_key_devtools_surveys_;
}

std::string metrics_key() const { return metrics_key_; }

Expand Down Expand Up @@ -338,7 +324,6 @@ class APIKeyCache {
std::string api_key_remoting_;
std::string api_key_sharing_;
std::string api_key_soda_;
std::string api_key_devtools_surveys_;
std::string metrics_key_;
std::string client_ids_[CLIENT_NUM_ITEMS];
std::string client_secrets_[CLIENT_NUM_ITEMS];
Expand Down Expand Up @@ -371,10 +356,6 @@ std::string GetSodaAPIKey() {
return g_api_key_cache.Get().api_key_soda();
}

std::string GetDevtoolsSurveysAPIKey() {
return g_api_key_cache.Get().api_key_devtools_surveys();
}

#if defined(OS_IOS)
void SetAPIKey(const std::string& api_key) {
g_api_key_cache.Get().set_api_key(api_key);
Expand Down
4 changes: 0 additions & 4 deletions google_apis/google_api_keys.h
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,6 @@ std::string GetSharingAPIKey();
// Retrieves the Speech On-Device API (SODA) API Key.
std::string GetSodaAPIKey();

// Retrieves the DevTools Survey API Key. Note there is no public API to replace
// this functionality.
std::string GetDevtoolsSurveysAPIKey();

#if defined(OS_IOS)
// Sets the API key. This should be called as early as possible before this
// API key is even accessed.
Expand Down

0 comments on commit 95c1668

Please sign in to comment.