Skip to content

Commit

Permalink
Fix DriveApiRequestsTest.EmptyBatchUploadRequest in official builds.
Browse files Browse the repository at this point in the history
Official builds don't include strings for CHECKs, so don't check for text.
Right now, the test is failing like so when doing an official build:

..\..\google_apis\drive\drive_api_requests_unittest.cc(2000): error: Death test: request->Commit()
    Result: died but not with expected error.
  Expected: Check failed
Actual msg:

BUG=467929
TBR=hirono@chromium.org

Review URL: https://codereview.chromium.org/1052553004

Cr-Commit-Position: refs/heads/master@{#325246}
  • Loading branch information
nico authored and Commit bot committed Apr 15, 2015
1 parent 0450d83 commit 932a905
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion google_apis/drive/drive_api_requests_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1997,7 +1997,7 @@ TEST_F(DriveApiRequestsTest, BatchUploadRequest) {
TEST_F(DriveApiRequestsTest, EmptyBatchUploadRequest) {
scoped_ptr<drive::BatchUploadRequest> request(new drive::BatchUploadRequest(
request_sender_.get(), *url_generator_));
EXPECT_DEATH(request->Commit(), "Check failed");
EXPECT_DEATH(request->Commit(), "");
}

} // namespace google_apis

0 comments on commit 932a905

Please sign in to comment.