Skip to content

Commit

Permalink
Revert "[OOR-CORS] Mark outofblink-cors/.../navigation-timing.https.h…
Browse files Browse the repository at this point in the history
…tml as PASS"

This reverts commit e87203b.

Reason for revert: This caused the Mojo builders to start failing: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Linux/16264

Test still fails with --enable-features=NetworkService

Original change's description:
> [OOR-CORS] Mark outofblink-cors/.../navigation-timing.https.html as PASS
> 
> external/wpt/service-workers/service-worker/navigation-timing.https.html
> has an expectation file consisting of two FAILs and one PASS, but in
> virtual/outofblink-cors[-ns] the test result changes to two PASSes and
> one FAIL. Since PASS is better than FAIL let's accept that result.
> 
> Bug: 736308
> Change-Id: I4bc33bf2c7c68b16528371cc1b0987dd6048e324
> Reviewed-on: https://chromium-review.googlesource.com/1144597
> Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576797}

TBR=falken@chromium.org,yhirano@chromium.org

Change-Id: I7424a1f9267ae4e7fcd0589752c6fae9e488df89
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 736308
Reviewed-on: https://chromium-review.googlesource.com/1145443
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576921}
  • Loading branch information
clarkduvall authored and Commit Bot committed Jul 20, 2018
1 parent 277b798 commit 92409c5
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 12 deletions.
2 changes: 2 additions & 0 deletions third_party/WebKit/LayoutTests/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -1691,6 +1691,7 @@ crbug.com/736308 virtual/outofblink-cors/external/wpt/service-workers/service-wo
crbug.com/736308 virtual/outofblink-cors/external/wpt/service-workers/service-worker/worker-in-sandboxed-iframe-by-csp-fetch-event.https.html [ Timeout ]

# Failing tests in dictionary order.
crbug.com/736308 virtual/outofblink-cors/external/wpt/service-workers/service-worker/navigation-timing.https.html [ Failure ]
crbug.com/736308 virtual/outofblink-cors/http/tests/fetch/chromium/error-messages.html [ Failure ]
crbug.com/736308 virtual/outofblink-cors/http/tests/xmlhttprequest/cross-origin-no-credential-prompt.html [ Failure ]
crbug.com/736308 virtual/outofblink-cors/http/tests/xmlhttprequest/cross-origin-unsupported-url.html [ Failure ]
Expand All @@ -1700,6 +1701,7 @@ crbug.com/736308 virtual/outofblink-cors/http/tests/xmlhttprequest/origin-whitel
crbug.com/736308 virtual/outofblink-cors/http/tests/xmlhttprequest/origin-whitelisting-subdomains.html [ Failure ]
crbug.com/736308 virtual/outofblink-cors/http/tests/xmlhttprequest/origin-whitelisting-ip-addresses.html [ Failure ]
crbug.com/736308 virtual/outofblink-cors/http/tests/xmlhttprequest/workers/cross-origin-unsupported-url.html [ Failure ]
crbug.com/736308 virtual/outofblink-cors-ns/external/wpt/service-workers/service-worker/navigation-timing.https.html [ Failure ]
crbug.com/736308 virtual/outofblink-cors-ns/http/tests/fetch/chromium/error-messages.html [ Failure ]
crbug.com/736308 virtual/outofblink-cors-ns/http/tests/xmlhttprequest/cross-origin-no-credential-prompt.html [ Failure ]
crbug.com/736308 virtual/outofblink-cors-ns/http/tests/xmlhttprequest/cross-origin-unsupported-url.html [ Failure ]
Expand Down

This file was deleted.

This file was deleted.

0 comments on commit 92409c5

Please sign in to comment.