Make android-pie-arm64-rel non-experimental.

This CL also filters out all failing and flaky tests. Bug: 765833, 1021665 Change-Id: Id9723495864ae2b9b2761649815242fa6da856c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979353 Reviewed-by: Aaron Gable <agable@chromium.org> Reviewed-by: Andrew Luo <aluo@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#728613}
marcosholgado · Jan 6, 2020 · 9025de5 · 9025de5
1 parent fc952a7
commit 9025de5
Show file tree

Hide file tree

Showing 6 changed files with 59 additions and 27 deletions.
diff --git a/infra/config/buckets/try.star b/infra/config/buckets/try.star
@@ -184,9 +184,7 @@ android_builder(
     cores = 16,
     goma_jobs = goma.jobs.J300,
     ssd = True,
-    tryjob = tryjob(
-        experiment_percentage = 100,
-    ),
+    tryjob = tryjob(),
 )
 
 android_builder(

diff --git a/infra/config/consoles/chromium.android.star b/infra/config/consoles/chromium.android.star
@@ -188,7 +188,7 @@ luci.console_view(
         ),
         luci.console_view_entry(
             builder = 'ci/android-pie-arm64-rel',
-            category = 'on_cq|future',
+            category = 'on_cq',
             short_name = 'P',
         ),
     ],

diff --git a/infra/config/generated/commit-queue.cfg b/infra/config/generated/commit-queue.cfg
@@ -89,7 +89,6 @@ config_groups: <
       >
       builders: <
         name: "chromium/try/android-pie-arm64-rel"
-        experiment_percentage: 100
       >
       builders: <
         name: "chromium/try/android-pie-x86-fyi-rel"

diff --git a/infra/config/generated/cq-builders.md b/infra/config/generated/cq-builders.md
@@ -19,6 +19,8 @@ These builders must pass before a CL may land.
 
 * [android-marshmallow-arm64-rel](https://ci.chromium.org/p/chromium/builders/try/android-marshmallow-arm64-rel) ([definition](https://cs.chromium.org/search?q=package:%5Echromium$+file:/cq.star$+-file:/beta/+-file:/stable/+android-marshmallow-arm64-rel)) ([matching builders](https://cs.chromium.org/search?q=+file:trybots.py+android-marshmallow-arm64-rel))
 
+* [android-pie-arm64-rel](https://ci.chromium.org/p/chromium/builders/try/android-pie-arm64-rel) ([definition](https://cs.chromium.org/search?q=package:%5Echromium$+file:/cq.star$+-file:/beta/+-file:/stable/+android-pie-arm64-rel)) ([matching builders](https://cs.chromium.org/search?q=+file:trybots.py+android-pie-arm64-rel))
+
 * [android_compile_dbg](https://ci.chromium.org/p/chromium/builders/try/android_compile_dbg) ([definition](https://cs.chromium.org/search?q=package:%5Echromium$+file:/cq.star$+-file:/beta/+-file:/stable/+android_compile_dbg)) ([matching builders](https://cs.chromium.org/search?q=+file:trybots.py+android_compile_dbg))
 
 * [android_cronet](https://ci.chromium.org/p/chromium/builders/try/android_cronet) ([definition](https://cs.chromium.org/search?q=package:%5Echromium$+file:/cq.star$+-file:/beta/+-file:/stable/+android_cronet)) ([matching builders](https://cs.chromium.org/search?q=+file:trybots.py+android_cronet))
@@ -315,9 +317,6 @@ These builders are run on some percentage of builds. Their results are ignored
 by CQ. These are often used to test new configurations before they are added
 as required builders.
 
-* [android-pie-arm64-rel](https://ci.chromium.org/p/chromium/builders/try/android-pie-arm64-rel) ([definition](https://cs.chromium.org/search?q=package:%5Echromium$+file:/cq.star$+-file:/beta/+-file:/stable/+android-pie-arm64-rel)) ([matching builders](https://cs.chromium.org/search?q=+file:trybots.py+android-pie-arm64-rel))
-  * Experiment percentage: 100
-
 * [fuchsia-compile-x64-dbg](https://ci.chromium.org/p/chromium/builders/try/fuchsia-compile-x64-dbg) ([definition](https://cs.chromium.org/search?q=package:%5Echromium$+file:/cq.star$+-file:/beta/+-file:/stable/+fuchsia-compile-x64-dbg)) ([matching builders](https://cs.chromium.org/search?q=+file:trybots.py+fuchsia-compile-x64-dbg))
   * Experiment percentage: 50
 
diff --git a/infra/config/generated/luci-milo.cfg b/infra/config/generated/luci-milo.cfg
@@ -812,7 +812,7 @@ consoles: <
   >
   builders: <
     name: "buildbucket/luci.chromium.ci/android-pie-arm64-rel"
-    category: "on_cq|future"
+    category: "on_cq"
     short_name: "P"
   >
   header: <

diff --git a/testing/buildbot/filters/android.pie_arm64_rel.chrome_public_test_apk.filter b/testing/buildbot/filters/android.pie_arm64_rel.chrome_public_test_apk.filter
@@ -1,58 +1,94 @@
--org.chromium.chrome.browser.autofill_assistant.AutofillAssistantGenericUiTest.testStaticUserInterface
+# crbug/1033877
+-org.chromium.chrome.browser.autofill_assistant.AutofillAssistantDirectActionHandlerTest.testReportAvailableDirectActions
+
+# crbug/1036413
 -org.chromium.chrome.browser.banners.AppBannerManagerTest.testBlockedAmbientBadgeDoesNotAppearAgainForMonths
--org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.testDictionaryDefinitions
--org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.testTapALot
--org.chromium.chrome.browser.directactions.DirectActionAvailabilityWebappTest.testCoreDirectActionInWebappActivity
+
+# crbug/1036417
 -org.chromium.chrome.browser.dom_distiller.DistilledPagePrefsTest.testSingleObserverFontFamily
 -org.chromium.chrome.browser.dom_distiller.DistilledPagePrefsTest.testSingleObserverFontScaling
 -org.chromium.chrome.browser.dom_distiller.DistilledPagePrefsTest.testSingleObserverTheme
+
+# crbug/963898
 -org.chromium.chrome.browser.download.DownloadMediaParserTest.testParseVideoH264
+
+# crbug/1018181
 -org.chromium.chrome.browser.download.home.DownloadActivityV2Test.testLaunchingActivity
+
+# crbug/1032118
 -org.chromium.chrome.browser.notifications.channels.ChannelsInitializerTest.testEnsureInitialized_permissionRequests
 -org.chromium.chrome.browser.notifications.channels.ChannelsInitializerTest.testEnsureInitialized_permissionRequestsHigh
 -org.chromium.chrome.browser.notifications.StandardNotificationBuilderTest.testSetAll
+
+# crbug/1036459
 -org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerViewTest.testDismissArticleWithContextMenu
 -org.chromium.chrome.browser.ntp.NewTabPageTest.testFocusFakebox
 -org.chromium.chrome.browser.ntp.NewTabPageTest.testOpenMostVisitedItemInIncognitoTab
 -org.chromium.chrome.browser.ntp.NewTabPageTest.testRemoveMostVisitedItem
 -org.chromium.chrome.browser.ntp.RecentTabsPageTest.testRecentlyClosedTabs
+
+# crbug/1035956
+-org.chromium.chrome.browser.payments.PaymentRequestNoShippingTest.testSaveNewCardAndNewBillingAddressAndPay
+-org.chromium.chrome.browser.payments.PaymentRequestRemoveBillingAddressTest.testPayWithCard
 -org.chromium.chrome.browser.payments.PaymentRequestRetryTest.testRetryWithShippingAddressErrorsAndPayerErrors
+
+# crbug/707528
 -org.chromium.chrome.browser.push_messaging.PushMessagingTest.testPushAndShowNotification
+
+# crbug/836460
 -org.chromium.chrome.browser.settings.autofill.AutofillProfilesFragmentTest.testKeyboardShownOnDpadCenter
--org.chromium.chrome.browser.shape_detection.ShapeDetectionTest.testBarcodeDetection
--org.chromium.chrome.browser.shape_detection.ShapeDetectionTest.testTextDetection
+
+# crbug/1036532
 -org.chromium.chrome.browser.signin.SigninTest.testConsumerSignin
+
+# crbug/1036545
 -org.chromium.chrome.browser.suggestions.tile.TileGroupTest.testDismissTileUndo
 -org.chromium.chrome.browser.suggestions.tile.TileGroupTest.testDismissTileWithContextMenu
+
+# crbug/1036551
 -org.chromium.chrome.browser.tabmodel.TabModelMergingTest.testMergeOnColdStartIntoChromeTabbedActivity2
+
+# crbug/1017141
+-org.chromium.chrome.browser.tasks.tab_management.TabSwitcherMultiWindowTest.testMoveTabsAcrossWindow_GTS_WithoutGroup
+
+# crbug/1036552
 -org.chromium.chrome.browser.tasks.tab_management.TabGridDialogParentTest.testDialog_ZoomInFadeOut
 -org.chromium.chrome.browser.tasks.tab_management.TabGridDialogParentTest.testDialog_ZoomInZoomOut
--org.chromium.chrome.browser.tasks.tab_management.TabSwitcherMultiWindowTest.testMoveTabsAcrossWindow_GTS_WithoutGroup
+
+# crbug/1036553
 -org.chromium.chrome.browser.translate.TranslateCompactInfoBarTest.testTabMenuDismissedOnOrientationChange
 -org.chromium.chrome.browser.translate.TranslateCompactInfoBarTest.testTranslateCompactInfoBarAppears
 -org.chromium.chrome.browser.translate.TranslateCompactInfoBarTest.testTranslateCompactInfoBarOverflowMenus
 -org.chromium.chrome.browser.translate.TranslateCompactInfoBarTest.testTranslateCompactInfoBarReopenOnTarget
+
+# crbug/1036556
 -org.chromium.chrome.browser.usage_stats.TabSuspensionTest.testMediaSuspension
 -org.chromium.chrome.browser.usage_stats.TabSuspensionTest.testMultiWindow
 -org.chromium.chrome.browser.usage_stats.TabSuspensionTest.testTabAddedFromCustomTab
--org.chromium.chrome.browser.webapps.WebApkActivityTest.testActivateWebApkLPlus
+-org.chromium.chrome.browser.usage_stats.TabSuspensionTest.testEagerSuspension
+-org.chromium.chrome.browser.usage_stats.TabSuspensionTest.testNavigateToSuspended
+-org.chromium.chrome.browser.usage_stats.TabSuspensionTest.testNavigateToSuspendedDomain_differentPage
+-org.chromium.chrome.browser.usage_stats.TabSuspensionTest.testNavigationFromSuspendedTabToInterstitial
+-org.chromium.chrome.browser.usage_stats.TabSuspensionTest.testNewTabSuspended
+-org.chromium.chrome.browser.usage_stats.TabSuspensionTest.testRendererCrashOnSuspendedTab
+-org.chromium.chrome.browser.usage_stats.TabSuspensionTest.testTabAddedInBackground
+-org.chromium.chrome.browser.usage_stats.TabSuspensionTest.testTabSwitchBackToSuspended
+-org.chromium.chrome.browser.usage_stats.TabSuspensionTest.testTabUnsuspendedInBackground
+
+# crbug/1023833
 -org.chromium.chrome.features.start_surface.StartSurfaceLayoutTest.testRenderGrid_10WebTabs
 -org.chromium.chrome.features.start_surface.StartSurfaceLayoutTest.testRenderGrid_Incognito
+
+# crbug/1036571
 -org.chromium.shape_detection.BarcodeDetectionImplTest.testDetectBarcodeWithHint
 -org.chromium.shape_detection.BarcodeDetectionImplTest.testDetectBarcodeWithoutHint
 -org.chromium.shape_detection.FaceDetectionImplTest.testDetectFacesInProfileWithGmsCore
 -org.chromium.shape_detection.FaceDetectionImplTest.testDetectRotatedFaceWithGmsCore
 -org.chromium.shape_detection.FaceDetectionImplTest.testDetectValidImageWithGmsCore
 -org.chromium.shape_detection.TextDetectionImplTest.testDetectSucceedsOnValidBitmap
--org.chromium.chrome.browser.autofill_assistant.AutofillAssistantDirectActionHandlerTest.testReportAvailableDirectActions
+-org.chromium.chrome.browser.shape_detection.ShapeDetectionTest.testBarcodeDetection
+-org.chromium.chrome.browser.shape_detection.ShapeDetectionTest.testTextDetection
+
+# crbug/1034412
 -org.chromium.chrome.browser.media.ui.PictureInPictureControllerTest.testEnterPip
 -org.chromium.chrome.browser.media.ui.PictureInPictureControllerTest.testReenterPip
--org.chromium.chrome.browser.usage_stats.TabSuspensionTest.testEagerSuspension
--org.chromium.chrome.browser.usage_stats.TabSuspensionTest.testNavigateToSuspended
--org.chromium.chrome.browser.usage_stats.TabSuspensionTest.testNavigateToSuspendedDomain_differentPage
--org.chromium.chrome.browser.usage_stats.TabSuspensionTest.testNavigationFromSuspendedTabToInterstitial
--org.chromium.chrome.browser.usage_stats.TabSuspensionTest.testNewTabSuspended
--org.chromium.chrome.browser.usage_stats.TabSuspensionTest.testRendererCrashOnSuspendedTab
--org.chromium.chrome.browser.usage_stats.TabSuspensionTest.testTabAddedInBackground
--org.chromium.chrome.browser.usage_stats.TabSuspensionTest.testTabSwitchBackToSuspended
--org.chromium.chrome.browser.usage_stats.TabSuspensionTest.testTabUnsuspendedInBackground