Skip to content

Commit

Permalink
Background tracing whitelist: Fix some strongly typed events
Browse files Browse the repository at this point in the history
Fix the allowlist used by the old filtering system to allow the
newly added strongly typed trace events, and re-add entries removed
accidentally.

R=ssid@chromium.org

Change-Id: I80ba44a19ed7f0be55650d16f325fc6377bcc42d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505626
Reviewed-by: ssid <ssid@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821874}
  • Loading branch information
Oystein Eftevaag authored and Commit Bot committed Oct 28, 2020
1 parent c27e8b5 commit 8d29639
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions services/tracing/public/cpp/trace_event_args_allowlist.cc
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ struct AllowlistEntry {
const char* const* arg_name_filter;
};

const char* const kScopedBlockingCallAllowedArgs[] = {"file_name",
"function_name", nullptr};
const char* const kScopedBlockingCallAllowedArgs[] = {
"file_name", "function_name", "source_location", nullptr};
const char* const kPeekMessageAllowedArgs[] = {"sent_messages_in_queue",
nullptr};
"chrome_message_pump", nullptr};
const char* const kFallbackFontAllowedArgs[] = {"font_name",
"primary_font_name", nullptr};
const char* const kGetFallbackFontsAllowedArgs[] = {"script", nullptr};
Expand All @@ -38,6 +38,8 @@ const char* const kMemoryDumpAllowedArgs[] = {
const char* const kRendererHostAllowedArgs[] = {
"class", "line", "should_background", "has_pending_views",
"bytes_allocated", nullptr};
const char* const kUIAllowedArgs[] = {
"dpi", "message_id", "chrome_window_handle_event_info", nullptr};
const char* const kV8GCAllowedArgs[] = {"num_items", "num_tasks", nullptr};
const char* const kTopLevelFlowAllowedArgs[] = {"task_queue_name", nullptr};
const char* const kTopLevelIpcRunTaskAllowedArgs[] = {"ipc_hash", nullptr};
Expand Down Expand Up @@ -95,6 +97,8 @@ const AllowlistEntry kEventArgsAllowlist[] = {
{TRACE_DISABLED_BY_DEFAULT("memory-infra"), "*", kMemoryDumpAllowedArgs},
{TRACE_DISABLED_BY_DEFAULT("system_stats"), "*", nullptr},
{TRACE_DISABLED_BY_DEFAULT("v8.gc"), "*", kV8GCAllowedArgs},
{"ui", "HWNDMessageHandler::OnWndProc", kUIAllowedArgs},
{"ui", "HWNDMessageHandler::OnDwmCompositionChanged", kUIAllowedArgs},
{"ui", "RenderTextHarfBuzz::FallbackFont", kFallbackFontAllowedArgs},
{"ui", "RenderTextHarfBuzz::GetFallbackFonts",
kGetFallbackFontsAllowedArgs},
Expand Down

0 comments on commit 8d29639

Please sign in to comment.