Skip to content

Commit

Permalink
Stop publishing llvm-cfi-verify.
Browse files Browse the repository at this point in the history
It never ended up being used for anything, and there are no plans to
change that.

Bug: 784953
Change-Id: Ie23a70ee120e5045f0cee1dec0a0f7cc1d40c155
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529663
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642435}
  • Loading branch information
nico authored and Commit Bot committed Mar 20, 2019
1 parent f9a93a5 commit 881420b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 16 deletions.
2 changes: 0 additions & 2 deletions docs/updating_clang.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ An archive of all packages built so far is at https://is.gd/chromeclang
gs://chromium-browser-clang/$x/clang-$rev.tgz ; \
gsutil.py cp -n -a public-read gs://chromium-browser-clang-staging/$x/llvmobjdump-$rev.tgz \
gs://chromium-browser-clang/$x/llvmobjdump-$rev.tgz ; \
gsutil.py cp -n -a public-read gs://chromium-browser-clang-staging/$x/llvmcfiverify-$rev.tgz \
gs://chromium-browser-clang/$x/llvmcfiverify-$rev.tgz ; \
gsutil.py cp -n -a public-read gs://chromium-browser-clang-staging/$x/translation_unit-$rev.tgz \
gs://chromium-browser-clang/$x/translation_unit-$rev.tgz ; \
gsutil.py cp -n -a public-read gs://chromium-browser-clang-staging/$x/llvm-code-coverage-$rev.tgz \
Expand Down
17 changes: 3 additions & 14 deletions tools/clang/scripts/package.py
Original file line number Diff line number Diff line change
Expand Up @@ -466,18 +466,6 @@ def main():
filter=PrintTarProgress)
MaybeUpload(args, objdumpdir, platform)

# Zip up llvm-cfi-verify for CFI coverage.
cfiverifydir = 'llvmcfiverify-' + stamp
shutil.rmtree(cfiverifydir, ignore_errors=True)
os.makedirs(os.path.join(cfiverifydir, 'bin'))
shutil.copy(os.path.join(LLVM_RELEASE_DIR, 'bin', 'llvm-cfi-verify' +
exe_ext),
os.path.join(cfiverifydir, 'bin'))
with tarfile.open(cfiverifydir + '.tgz', 'w:gz') as tar:
tar.add(os.path.join(cfiverifydir, 'bin'), arcname='bin',
filter=PrintTarProgress)
MaybeUpload(args, cfiverifydir, platform)

# On Mac, lld isn't part of the main zip. Upload it in a separate zip.
if sys.platform == 'darwin':
llddir = 'lld-' + stamp
Expand All @@ -494,8 +482,9 @@ def main():
filter=PrintTarProgress)
MaybeUpload(args, llddir, platform)

# dsymutil isn't part of the main zip either, and it gets periodically deployed to CIPD
# (manually, not as part of clang rolls) for use in the Mac build toolchain.
# dsymutil isn't part of the main zip either, and it gets periodically
# deployed to CIPD (manually, not as part of clang rolls) for use in the
# Mac build toolchain.
dsymdir = 'dsymutil-' + stamp
shutil.rmtree(dsymdir, ignore_errors=True)
os.makedirs(os.path.join(dsymdir, 'bin'))
Expand Down

0 comments on commit 881420b

Please sign in to comment.