forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Test suite covering both KURL and GURL.
This CL adds an AbstractUrlTest test suite that covers both KURL and GURL. Having tests that are shared across Blink and //url will help 1) avoid code duplication and 2) ensure that Blink and //url behave in the same way (at least wrt things covered by the shared tests). Bug: 1164416 Change-Id: I6812c0230cc1ef91416aa9a8f967a5db15d4bf77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622736 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#842560}
- Loading branch information
1 parent
1134c11
commit 875905b
Showing
4 changed files
with
181 additions
and
79 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,139 @@ | ||
| // Copyright 2021 The Chromium Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| #ifndef URL_GURL_ABSTRACT_TESTS_H_ | ||
| #define URL_GURL_ABSTRACT_TESTS_H_ | ||
|
|
||
| // AbstractUrlTest below abstracts away differences between GURL and blink::KURL | ||
| // by parametrizing the tests with a class that has to be derived from | ||
| // UrlTraitsBase below. | ||
| template <typename TConcreteUrlType> | ||
| class UrlTraitsBase { | ||
| public: | ||
| using UrlType = TConcreteUrlType; | ||
| UrlTraitsBase() = default; | ||
|
|
||
| // Constructing an origin. | ||
| virtual UrlType CreateUrlFromString(base::StringPiece s) = 0; | ||
|
|
||
| // Accessors for origin properties. | ||
| virtual bool IsAboutBlank(const UrlType& url) = 0; | ||
| virtual bool IsAboutSrcdoc(const UrlType& url) = 0; | ||
|
|
||
| // This type is non-copyable and non-moveable. | ||
| UrlTraitsBase(const UrlTraitsBase&) = delete; | ||
| UrlTraitsBase& operator=(const UrlTraitsBase&) = delete; | ||
| }; | ||
|
|
||
| // Test suite for tests that cover both url::Url and blink::SecurityUrl. | ||
| template <typename TUrlTraits> | ||
| class AbstractUrlTest : public testing::Test { | ||
| static_assert(std::is_base_of<UrlTraitsBase<typename TUrlTraits::UrlType>, | ||
| TUrlTraits>::value, | ||
| "TUrlTraits needs to expose the right members."); | ||
|
|
||
| protected: | ||
| // Wrappers that allow tests to ignore presence of `url_traits_`. | ||
| // | ||
| // Note that calling the wrappers needs to be prefixed with `this->...` to | ||
| // avoid hitting: explicit qualification required to use member 'IsAboutBlank' | ||
| // from dependent base class. | ||
| using UrlType = typename TUrlTraits::UrlType; | ||
| UrlType CreateUrlFromString(base::StringPiece s) { | ||
| return url_traits_.CreateUrlFromString(s); | ||
| } | ||
| bool IsAboutBlank(const UrlType& url) { | ||
| return url_traits_.IsAboutBlank(url); | ||
| } | ||
| bool IsAboutSrcdoc(const UrlType& url) { | ||
| return url_traits_.IsAboutSrcdoc(url); | ||
| } | ||
|
|
||
| private: | ||
| TUrlTraits url_traits_; | ||
| }; | ||
|
|
||
| TYPED_TEST_SUITE_P(AbstractUrlTest); | ||
|
|
||
| TYPED_TEST_P(AbstractUrlTest, IsAboutBlankTest) { | ||
| // See https://tools.ietf.org/html/rfc6694 which explicitly allows | ||
| // `about-query` and `about-fragment` parts in about: URLs. | ||
| const std::string kAboutBlankUrls[] = {"about:blank", "about:blank?foo", | ||
| "about:blank/#foo", | ||
| "about:blank?foo#foo"}; | ||
| for (const auto& input : kAboutBlankUrls) { | ||
| SCOPED_TRACE(testing::Message() << "Test input: " << input); | ||
| auto url = this->CreateUrlFromString(input); | ||
| EXPECT_TRUE(this->IsAboutBlank(url)); | ||
| } | ||
|
|
||
| const std::string kNotAboutBlankUrls[] = {"", | ||
| "about", | ||
| "about:", | ||
| "about:blanky", | ||
| "about:blan", | ||
| "about:about:blank:", | ||
| "data:blank", | ||
| "http:blank", | ||
| "about://blank", | ||
| "about:blank/foo", | ||
| "about://:8000/blank", | ||
| "about://foo:foo@/blank", | ||
| "foo@about:blank", | ||
| "foo:bar@about:blank", | ||
| "about:blank:8000", | ||
| "about:blANk"}; | ||
| for (const auto& input : kNotAboutBlankUrls) { | ||
| SCOPED_TRACE(testing::Message() << "Test input: " << input); | ||
| auto url = this->CreateUrlFromString(input); | ||
| EXPECT_FALSE(this->IsAboutBlank(url)); | ||
| } | ||
| } | ||
|
|
||
| TYPED_TEST_P(AbstractUrlTest, IsAboutSrcdocTest) { | ||
| // See https://tools.ietf.org/html/rfc6694 which explicitly allows | ||
| // `about-query` and `about-fragment` parts in about: URLs. | ||
| // | ||
| // `about:srcdoc` is defined in | ||
| // https://html.spec.whatwg.org/multipage/urls-and-fetching.html#about:srcdoc | ||
| // which refers to rfc6694 for details. | ||
| const std::string kAboutSrcdocUrls[] = { | ||
| "about:srcdoc", "about:srcdoc/", "about:srcdoc?foo", "about:srcdoc/#foo", | ||
| "about:srcdoc?foo#foo"}; | ||
| for (const auto& input : kAboutSrcdocUrls) { | ||
| SCOPED_TRACE(testing::Message() << "Test input: " << input); | ||
| auto url = this->CreateUrlFromString(input); | ||
| EXPECT_TRUE(this->IsAboutSrcdoc(url)); | ||
| } | ||
|
|
||
| const std::string kNotAboutSrcdocUrls[] = {"", | ||
| "about", | ||
| "about:", | ||
| "about:srcdocx", | ||
| "about:srcdo", | ||
| "about:about:srcdoc:", | ||
| "data:srcdoc", | ||
| "http:srcdoc", | ||
| "about:srcdo", | ||
| "about://srcdoc", | ||
| "about://srcdoc\\", | ||
| "about:srcdoc/foo", | ||
| "about://:8000/srcdoc", | ||
| "about://foo:foo@/srcdoc", | ||
| "foo@about:srcdoc", | ||
| "foo:bar@about:srcdoc", | ||
| "about:srcdoc:8000", | ||
| "about:srCDOc"}; | ||
| for (const auto& input : kNotAboutSrcdocUrls) { | ||
| SCOPED_TRACE(testing::Message() << "Test input: " << input); | ||
| auto url = this->CreateUrlFromString(input); | ||
| EXPECT_FALSE(this->IsAboutSrcdoc(url)); | ||
| } | ||
| } | ||
|
|
||
| REGISTER_TYPED_TEST_SUITE_P(AbstractUrlTest, | ||
| IsAboutBlankTest, | ||
| IsAboutSrcdocTest); | ||
|
|
||
| #endif // URL_GURL_ABSTRACT_TESTS_H_ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters