Skip to content

Commit

Permalink
Do not import WPT WebDriver tests that have spaces
Browse files Browse the repository at this point in the history
Test names with spaces are causing syntax errors in expectation files.

TBR to unblock wpt-importer; no-try because this file is only used by
the importer.

TBR=foolip

No-Try: True
Bug: 974254
Change-Id: Ia15bf96f59fe5fdaa97828ff4bf464b578e90c20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660355
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669259}
  • Loading branch information
Hexcles authored and Commit Bot committed Jun 14, 2019
1 parent 3c94fcc commit 86fc2a5
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions third_party/blink/web_tests/W3CImportExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -464,3 +464,13 @@ external/wpt/uievents/order-of-events/mouse-events/mousemove-between-manual.html
# Tests that fail in content_shell but pass when run manually.
external/wpt/client-hints/accept_ch_lifetime.https.html [ Skip ]
external/wpt/client-hints/accept_ch.https.html [ Skip ]

# TODO(crbug.com/974254): Remove the following once we can handle spaces in test names.
external/wpt/webdriver/tests/element_click/interactability.py
external/wpt/webdriver/tests/find_element/find.py
external/wpt/webdriver/tests/find_element_from_element/find.py
external/wpt/webdriver/tests/find_elements/find.py
external/wpt/webdriver/tests/find_elements_from_element/find.py
external/wpt/webdriver/tests/new_session/invalid_capabilities.py
external/wpt/webdriver/tests/new_session/response.py
external/wpt/webdriver/tests/send_alert_text/send.py

0 comments on commit 86fc2a5

Please sign in to comment.